improve some symlink checks

Author: mortenpi

src/MultiDocumenter.jl

@@ -74,6 +74,12 @@ function walk_outputs(f, root, docs::Vector{MultiDocRef}, dirs::Vector{String})
         p = joinpath(root, ref.path)
         for dir in dirs
             dirpath = joinpath(p, dir)
+            # Symlinks do not really work on Windows. There are permissions problems and we can not
+            # actually traverse them.
+            if Sys.iswindows() && islink(dirpath)
+                @warn "[WINDOWS] Symlink encountered at $(dirpath) -- excluding from search index, since symlinks are not properly supported on Windows."
+                continue
+            end
             isdir(dirpath) || continue
             DocumenterTools.walkdocs(dirpath, DocumenterTools.isdochtml) do fileinfo
                 f(relpath(dirname(fileinfo.fullpath), root), fileinfo.fullpath)

src/documentertools/canonical_urls.jl

@@ -101,7 +101,9 @@ function update_canonical_links(docs_directory::AbstractString; canonical::Abstr
         # We'll skip all files. This includes files such as index.html, which in this
         # directory will likely be the redirect. Also, links should be pointing to other
         # versions, so we'll skip them too.
-        if !isdir(path) || islink(path)
+        # Note: we need to check islink() first, because on windows, calling isdir() on a
+        # symlink can make it throw a permissions IOError...
+        if islink(path) || !isdir(path)
             continue
         end
         # Preview directory is should contain other Documenter directories, so we just add