Skip to content

Allow for non-string names #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Allow for non-string names #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5213150
renamed search... to search everywhere
behinger Feb 6, 2025
bde66b5
relax name for custom CSS
behinger Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/default/flexsearch_integration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
})

Promise.all(promises).then(() => {
input.setAttribute('placeholder', 'Search...')
input.setAttribute('placeholder', 'Search everywhere...')
successfullyLoadedIndex = true
}).catch(() => {
input.setAttribute('placeholder', 'Error loading search data...')
Expand Down
2 changes: 1 addition & 1 deletion src/MultiDocumenter.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Represents one set of docs that will get an entry in the MultiDocumenter navigat
struct MultiDocRef
upstream::String
path::String
name::String
name::Any
fix_canonical_url::Bool
giturl::String
branch::String
Expand Down
2 changes: 1 addition & 1 deletion src/search/flexsearch.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ end
function render()
return @htl """
<div class="search nav-item">
<input id="search-input" placeholder="Search...">
<input id="search-input" placeholder="Search everywhere...">
<ul id="search-result-container" class="suggestions hidden">
</ul>
<div class="search-keybinding">/</div>
Expand Down
2 changes: 1 addition & 1 deletion src/search/stork.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ end
function render()
return @htl """
<div class="search nav-item stork-wrapper">
<input id="search-input" class="stork-input" data-stork="multidocumenter" placeholder="Search...">
<input id="search-input" class="stork-input" data-stork="multidocumenter" placeholder="Search everywhere..">
<div data-stork="multidocumenter-output" class="stork-output"></div>
<div class="search-keybinding">/</div>
</div>
Expand Down
Loading