update tests (#29)

Update tests for #28.
Add some diagnostic messages to troubleshoot CI.

Author: tanmaykm

test/client/petstore_v3/petstore_test_userapi.jl

@@ -12,6 +12,7 @@ import OpenAPI.Clients: Client, Ctx, ApiException, DEFAULT_TIMEOUT_SECS, with_ti
 const TEST_USER = "jloac"
 const TEST_USER1 = "jloac1"
 const TEST_USER2 = "jloac2"
+const TEST_USER3 = "jl oac 3"
 const PRESET_TEST_USER = "user1"    # this is the username that works for get user requests (as documented in the test docker container API)
 
 function test_404(uri)
@@ -171,6 +172,21 @@ function test(uri)
     @test http_resp.status == 200
     @test logout_result === nothing
 
+    @info("UserApi - Test with spaces in username")
+    user3 = User(; id=300, username=TEST_USER3, firstName="test3", lastName="user3", email="[email protected]", password="testpass3", phone="1000000003", userStatus=0)
+    create_result, http_resp = create_user(api, user3)
+    @test http_resp.status == 200
+    @test create_result === nothing
+
+    user3.firstName = "test3 updated"
+    api_return, http_resp = update_user(api, TEST_USER3, user3)
+    @test http_resp.status == 200
+    @test api_return === nothing
+
+    api_return, http_resp = delete_user(api, TEST_USER3)
+    @test http_resp.status == 200
+    @test api_return === nothing
+
     nothing
 end
 

test/runtests.jl

@@ -36,6 +36,12 @@ include("client/allany/runtests.jl")
             end
             servers_running && OpenAPIClientTests.runtests()
         finally
+            if run_tests_with_servers && !servers_running
+                # we probably had an error starting the servers
+                v2_out_str = isnothing(v2_out) ? "" : String(take!(v2_out))
+                v3_out_str = isnothing(v3_out) ? "" : String(take!(v3_out))
+                @warn("Servers not running", v2_ret=v2_ret, v2_out_str, v3_ret=v3_ret, v3_out_str)
+            end
             if run_tests_with_servers
                 stop_server(8080, v2_ret, v2_out)
                 stop_server(8081, v3_ret, v3_out)
@@ -56,6 +62,11 @@ include("client/allany/runtests.jl")
                 servers_running = false
             end
         finally
+            if run_tests_with_servers && !servers_running
+                # we probably had an error starting the servers
+                out_str = isnothing(out) ? "" : String(take!(out))
+                @warn("Servers not running", ret=ret, out_str)
+            end
             run_tests_with_servers && stop_server(8081, ret, out)
         end
     end
@@ -75,6 +86,11 @@ include("client/allany/runtests.jl")
                 servers_running = false
             end
         finally
+            if run_tests_with_servers && !servers_running
+                # we probably had an error starting the servers
+                out_str = isnothing(out) ? "" : String(take!(out))
+                @warn("Servers not running", ret=ret, out_str)
+            end
             run_tests_with_servers && stop_server(8081, ret, out)
         end
     end

test/testutils.jl

@@ -9,14 +9,16 @@ const startup_flag = `--startup-file=no`
 const run_tests_with_servers = get(ENV, "RUNNER_OS", "") == "Linux"
 
 function run_server(script, flags=``)
-    srvrscript = joinpath(dirname(@__FILE__), script)
-    srvrcmd = `$(joinpath(Sys.BINDIR, "julia")) $startup_flag $cov_flag $inline_flag $script $flags`
+    use_pkgimages = VERSION >= v"1.9" ? `--pkgimages=no` : ``
+    srvrcmd = `$(joinpath(Sys.BINDIR, "julia")) $use_pkgimages $startup_flag $cov_flag $inline_flag $script $flags`
+    srvrcmd = addenv(srvrcmd,
+        "JULIA_DEPOT_PATH"=>join(DEPOT_PATH, Sys.iswindows() ? ';' : ':'),
+        "JULIA_LOAD_PATH"=>ENV["JULIA_LOAD_PATH"],
+    )
     iob = IOBuffer()
     pipelined_cmd = pipeline(srvrcmd, stdout=iob, stderr=iob)
-    ret = withenv("JULIA_DEPOT_PATH"=>join(DEPOT_PATH, Sys.iswindows() ? ';' : ':')) do
-        @info("Launching ", script, srvrcmd, JULIA_DEPOT_PATH=ENV["JULIA_DEPOT_PATH"])
-        run(pipelined_cmd, wait=false)
-    end
+    @info("Launching ", script, srvrcmd)
+    ret = run(pipelined_cmd, wait=false)
 
     return ret, iob
 end
@@ -55,7 +57,8 @@ function stop_server(port, proc, iob)
         wait(proc)
         @info("Stopped server", port)
     catch ex
-        @warn("Error waiting for server", port, server_logs=String(take!(iob)), exception=(ex, catch_backtrace()))
+        server_logs = isnothing(iob) ? "" : String(take!(iob))
+        @warn("Error waiting for server", port, server_logs, exception=(ex, catch_backtrace()))
         return false
     end