Merge pull request #35 from JuliaComputing/sp/no-wait-for-open_browser-cmds

fix: stop waiting for browsers

Author: pfitzseb

.github/workflows/CI.yml

@@ -27,8 +27,9 @@ jobs:
           - '1.4'
           - '1.5'
           - '1.6'
-          # - '1.7' # TODO: uncomment this line once Julia 1.8 is released
-          - '~1.8.0-rc1' # TODO: delete this line once Julia 1.8 is released
+          - '1.7'
+          - '1.8'
+          - '1.9'
           - '1' # automatically expands to the latest stable 1.x release
           - 'nightly'
         os:

src/PkgAuthentication.jl

@@ -521,11 +521,11 @@ function open_browser(url::AbstractString)
                 return false
             end
         elseif Sys.iswindows()
-            run(`cmd /c "start $url"`)
+            run(`cmd /c "start $url"`; wait=false)
         elseif Sys.isapple()
-            run(`open $url`)
+            run(`open $url`; wait=false)
         elseif Sys.islinux() || Sys.isbsd()
-            run(`xdg-open $url`)
+            run(`xdg-open $url`; wait=false)
         end
     catch err
         @warn "There was a problem opening the authentication URL in a browser, please try opening this URL manually to authenticate." url, error = err