Skip to content

Commit 7e807a2

Browse files
committed
clean up code a bit
1 parent 14e6c37 commit 7e807a2

File tree

1 file changed

+15
-8
lines changed

1 file changed

+15
-8
lines changed

src/TableView.jl

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -80,28 +80,35 @@ function _showtable_async(table, dark)
8080
types[i] <: Union{Missing, T where T <: Number} ? "agNumberColumnFilter" : nothing
8181
) for (i, n) in enumerate(names)]
8282

83-
rowinds = Observable(w, "startrow", [1, 100, ""])
84-
requestedrows = Observable(w, "requestedrows", "[]")
85-
on(rowinds) do x
86-
requestedrows[] = table2json(rows, names, types, requested = x[1:2])
83+
rowparams = Observable(w, "rowparams", Dict("startRow" => 1,
84+
"endRow" => 100,
85+
"successCallback" => @js v -> nothing))
86+
requestedrows = Observable(w, "requestedrows", "")
87+
on(rowparams) do x
88+
requestedrows[] = table2json(rows, names, types, requested = [x["startRow"], x["endRow"]])
8789
end
8890

8991
onjs(requestedrows, @js function (val)
90-
$rowinds[][2](JSON.parse(val))
92+
($rowparams[]).successCallback(JSON.parse(val), $(length(rows)))
9193
end)
9294

9395
options = Dict(
9496
:columnDefs => coldefs,
95-
# :enableSorting => true,
96-
# :enableFilter => true,
97+
:enableSorting => true,
98+
:enableFilter => true,
99+
:maxConcurrentDatasourceRequests => 1,
100+
:cacheBlockSize => 1000,
101+
:maxBlocksInCache => 100,
97102
:enableColResize => true,
98103
:multiSortKey => "ctrl",
99104
:rowModelType => "infinite",
100105
:datasource => Dict(
101106
"getRows" =>
102107
@js function (rowParams)
103-
$rowinds[] = [rowParams.startRow, rowParams.endRow, rowParams.successCallback]
108+
$rowparams[] = rowParams
104109
end
110+
,
111+
"rowCount" => length(rows)
105112
)
106113
)
107114

0 commit comments

Comments
 (0)