#62 use isa instead of ==

Ben Baumgold · Ben Baumgold · commit 8d37ba6a5e51 · 2020-12-31T14:14:29.000Z
diff --git a/src/TableView.jl b/src/TableView.jl
@@ -69,7 +69,7 @@ function showtable(table, options::Dict{Symbol, Any} = Dict{Symbol, Any}();
     )
     rows = Tables.rows(table)
     it_sz = Base.IteratorSize(rows)
-    has_len = it_sz == Base.HasLength() || it_sz == Base.HasShape{1}()
+    has_len = it_sz isa Base.HasLength || it_sz isa Base.HasShape
     tablelength = has_len ? length(rows) : nothing
 
     if height === :auto

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ function showtable(table, options::Dict{Symbol, Any} = Dict{Symbol, Any}();`
`69`	`69`	`)`
`70`	`70`	`rows = Tables.rows(table)`
`71`	`71`	`it_sz = Base.IteratorSize(rows)`
`72`		`- has_len = it_sz == Base.HasLength() \|\| it_sz == Base.HasShape{1}()`
	`72`	`+ has_len = it_sz isa Base.HasLength \|\| it_sz isa Base.HasShape`
`73`	`73`	`tablelength = has_len ? length(rows) : nothing`
`74`	`74`
`75`	`75`	`if height === :auto`