Merge pull request #13 from JuliaComputing/sp/fixversion

use fixed ag-grid version

Author: pfitzseb

ag-grid.version

@@ -0,0 +1 @@
+20.1.0

deps/.gitignore

@@ -1,2 +1,2 @@
-ag-grid
+ag-grid*
 build.log

deps/build.jl

@@ -1,13 +1,15 @@
-isdir(joinpath(@__DIR__, "ag-grid")) || mkdir(joinpath(@__DIR__, "ag-grid"))
+version = readchomp(joinpath(@__DIR__, "..", "ag-grid.version"))
 
-ag_grid_base = joinpath(@__DIR__, "ag-grid", "ag-grid.js")
-isfile(ag_grid_base) || download("https://unpkg.com/ag-grid-community/dist/ag-grid-community.min.noStyle.js", ag_grid_base)
+isdir(joinpath(@__DIR__, "ag-grid-$(version)")) || mkdir(joinpath(@__DIR__, "ag-grid-$(version)"))
 
-ag_grid_base_style = joinpath(@__DIR__, "ag-grid", "ag-grid.css")
-isfile(ag_grid_base_style) || download("https://unpkg.com/ag-grid-community/dist/styles/ag-grid.css", ag_grid_base_style)
+ag_grid_base = joinpath(@__DIR__, "ag-grid-$(version)", "ag-grid.js")
+isfile(ag_grid_base) || download("https://unpkg.com/ag-grid-community@$(version)/dist/ag-grid-community.min.noStyle.js", ag_grid_base)
 
-ag_grid_light = joinpath(@__DIR__, "ag-grid", "ag-grid-light.css")
-isfile(ag_grid_light) || download("https://unpkg.com/ag-grid-community/dist/styles/ag-theme-balham.css", ag_grid_light)
+ag_grid_base_style = joinpath(@__DIR__, "ag-grid-$(version)", "ag-grid.css")
+isfile(ag_grid_base_style) || download("https://unpkg.com/ag-grid-community@$(version)/dist/styles/ag-grid.css", ag_grid_base_style)
 
-ag_grid_dark = joinpath(@__DIR__, "ag-grid", "ag-grid-dark.css")
-isfile(ag_grid_dark) || download("https://unpkg.com/ag-grid-community/dist/styles/ag-theme-balham-dark.css", ag_grid_dark)
+ag_grid_light = joinpath(@__DIR__, "ag-grid-$(version)", "ag-grid-light.css")
+isfile(ag_grid_light) || download("https://unpkg.com/ag-grid-community@$(version)/dist/styles/ag-theme-balham.css", ag_grid_light)
+
+ag_grid_dark = joinpath(@__DIR__, "ag-grid-$(version)", "ag-grid-dark.css")
+isfile(ag_grid_dark) || download("https://unpkg.com/ag-grid-community@$(version)/dist/styles/ag-theme-balham-dark.css", ag_grid_dark)

src/TableView.jl

@@ -9,9 +9,10 @@ export showtable
 const ag_grid_imports = []
 
 function __init__()
+    version = readchomp(joinpath(@__DIR__, "..", "ag-grid.version"))
     empty!(ag_grid_imports)
     for f in ["ag-grid.js", "ag-grid.css", "ag-grid-light.css", "ag-grid-dark.css"]
-        push!(ag_grid_imports, normpath(joinpath(@__DIR__, "..", "deps", "ag-grid", f)))
+        push!(ag_grid_imports, normpath(joinpath(@__DIR__, "..", "deps", "ag-grid-$(version)", f)))
     end
 end
 

test/runtests.jl

@@ -1,7 +1,9 @@
 using TableView
 using Test, WebIO
 
-@test isfile(joinpath(@__DIR__, "..", "deps", "ag-grid", "ag-grid.js"))
+version = readchomp(joinpath(@__DIR__, "..", "ag-grid.version"))
+
+@test isfile(joinpath(@__DIR__, "..", "deps", "ag-grid-$(version)", "ag-grid.js"))
 
 nttable = [
     (a = 2.0, b = 3),