Skip to content

Commit 3d41fbc

Browse files
committed
improve test coverage slightly
1 parent e05440b commit 3d41fbc

File tree

2 files changed

+7
-13
lines changed

2 files changed

+7
-13
lines changed

lib/ControlSystemsBase/ext/ControlSystemsBaseMakieExt.jl

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -372,18 +372,6 @@ function CSMakie.marginplot!(fig, systems::Union{LTISystem, AbstractVector{<:LTI
372372
allMargins=true,
373373
adjust_phase_start)
374374

375-
# Limit number of margins shown
376-
if length(gm) > 5
377-
idx = sortperm(gm)
378-
wgm = wgm[idx[1:5]]
379-
gm = gm[idx[1:5]]
380-
end
381-
if length(pm) > 5
382-
idx = sortperm(pm)
383-
wpm = wpm[idx[1:5]]
384-
pm = pm[idx[1:5]]
385-
end
386-
387375
# Magnitude plot
388376
ax_mag = axes_mag[i, j]
389377
magdata = vec(bmag[i, j, :])

lib/ControlSystemsBase/test/test_makie_plots.jl

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ import CairoMakie.Makie
6565
@test fig isa Makie.Figure
6666
end
6767
@test_nowarn begin
68-
fig = CSMakie.nyquistplot(P, w; Ms_circles=[1.5, 2.0])
68+
fig = CSMakie.nyquistplot(P, w; Ms_circles=[1.5, 2.0], Mt_circles=[1.5, 2.0])
6969
@test fig isa Makie.Figure
7070
end
7171
@test_nowarn begin
@@ -136,6 +136,12 @@ import CairoMakie.Makie
136136
Makie.plot!(fig[1,2], res, plotu=true, plotx=true)
137137
@test fig isa Makie.Figure
138138
end
139+
140+
res = step(Pmimo, t)
141+
@test_nowarn begin
142+
fig = Makie.plot(res; plotu=true)
143+
@test fig isa Makie.Figure
144+
end
139145
end
140146

141147
@testset "StepInfo plot" begin

0 commit comments

Comments
 (0)