Skip to content

Commit 8f2f89b

Browse files
committed
use unique numbers in tests
to avoid things by chance passing due to `1*1 = 1` etc.
1 parent fd5e6b0 commit 8f2f89b

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

lib/ControlSystemsBase/test/test_pid_design.jl

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,24 +57,24 @@ Css = pid(1,1,1, Tf=0.1, d = 1, state_space=true)
5757
@test all(p->imag(p) == 0, poles(Css))
5858
@test tf(Css) Ctf
5959

60-
Ctf = pid(1,0,1, Tf=0.1, d = 0.9)
61-
Css = pid(1,0,1, Tf=0.1, d = 0.9, state_space=true)
60+
Ctf = pid(1.1,0,1.2, Tf=0.1, d = 0.9)
61+
Css = pid(1.1,0,1.2, Tf=0.1, d = 0.9, state_space=true)
6262
@test tf(Css) Ctf
6363

6464
# test filter order 1
6565
# All params
66-
Ctf = pid(1.0, 1, 1, Tf=0.1, filter_order=1)
67-
Css = pid(1.0, 1, 1, Tf=0.1, filter_order=1, state_space=true)
66+
Ctf = pid(1.1, 1.2, 1.5, Tf=0.1, filter_order=1)
67+
Css = pid(1.1, 1.2, 1.5, Tf=0.1, filter_order=1, state_space=true)
6868
@test freqresptest(Ctf, Css) < 1e-10
6969

7070
# No Ki
71-
Ctf = pid(1.0, 0, 1, Tf=0.1, filter_order=1)
72-
Css = pid(1.0, 0, 1, Tf=0.1, filter_order=1, state_space=true)
71+
Ctf = pid(1.1, 0.2, 1.5, Tf=0.1, filter_order=1)
72+
Css = pid(1.1, 0.2, 1.5, Tf=0.1, filter_order=1, state_space=true)
7373
@test freqresptest(Ctf, Css) < 1e-10
7474

7575
# No Kd (no filter either in this case)
76-
Ctf = pid(1.0, 1, 0, Tf=0.1, filter_order=1)
77-
Css = pid(1.0, 1, 0, Tf=0.1, filter_order=1, state_space=true)
76+
Ctf = pid(1.1, 1.2, 0, Tf=0.1, filter_order=1)
77+
Css = pid(1.1, 1.2, 0, Tf=0.1, filter_order=1, state_space=true)
7878
@test freqresptest(Ctf, Css) < 1e-10
7979

8080
# bodeplot([Ctf, Css])

0 commit comments

Comments
 (0)