Skip to content

Conversation

@CasBex
Copy link
Contributor

@CasBex CasBex commented Jan 29, 2025

The docstring of ssdata lead me to believe that the matrices A, B, C, D were copies of those of sys. I suggest to change the documentation as in this PR to avoid confusion.

@baggepinnen baggepinnen merged commit 710b5c2 into JuliaControl:master Jan 29, 2025
@baggepinnen
Copy link
Member

baggepinnen commented Jan 29, 2025

Nowadays, you can also do

(;A, B, C, D) = sys

which works for any Julia type

@CasBex CasBex deleted the improve_docstring branch January 29, 2025 15:01
@CasBex
Copy link
Contributor Author

CasBex commented Jan 29, 2025

It's indeed not the most rocket sciencey function in this library, but it took two hours of debugging, so I hope to spare others the same fate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants