Skip to content

Conversation

@franckgaga
Copy link
Member

@franckgaga franckgaga commented Jun 12, 2025

Constructing with e.g.:

mpc = LinMPC(model, M_Hp=Hermitian(diagm(ones(10)))

was crashing. I added generic dispatch to convert correctly and handle all matrix types correctly.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.70%. Comparing base (61de78d) to head (debae4d).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/general.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   98.74%   98.70%   -0.05%     
==========================================
  Files          26       26              
  Lines        4306     4308       +2     
==========================================
  Hits         4252     4252              
- Misses         54       56       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@franckgaga franckgaga merged commit 336eaf3 into main Jun 13, 2025
4 checks passed
@franckgaga franckgaga deleted the debug_hermitian_weights branch September 16, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants