added: use Ipopt._VectorNonlinearOracle in MovingHorizonEstimator
#268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
- Coverage 94.30% 92.43% -1.88%
==========================================
Files 26 26
Lines 4551 4612 +61
==========================================
- Hits 4292 4263 -29
- Misses 259 349 +90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
|
Within a week |
|
Or, like, today 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing a test that does not run for now with
Ipopt. It was only for coverage. These sections of the code will be entirely removed once I finish migration toMOI.VectorNonlinearOracle. So coverage decreases in this PR, but it will re-increase later when I will remove these sections.I do not plan to release a new version before finishing the migration to
MOI.VectorNonlinearOracle. From the github activity, it seems that I can expect a new release of MOI in the short term, am I right @odow ? Also can I expect that the set will also work with MadNLP.jl ? Thanks!