Remove deprecations (#419)

In preparation of 1.0. These have been in place for years,
it's unlikely people rely on them ayway.

Author: nalimilan

src/CategoricalArrays.jl

@@ -33,8 +33,6 @@ module CategoricalArrays
     include("extras.jl")
     include("recode.jl")
 
-    include("deprecated.jl")
-
     if !isdefined(Base, :get_extension)
         using Requires: @require
     end

src/array.jl

@@ -790,13 +790,7 @@ entries corresponding to omitted levels will be set to `missing`.
 Else, `newlevels` must include all levels which appear in the data.
 """
 function levels!(A::CategoricalArray{T, N, R}, newlevels::AbstractVector;
-                 allowmissing::Bool=false,
-                 allow_missing::Union{Bool, Nothing}=nothing) where {T, N, R}
-    if allow_missing !== nothing
-        Base.depwarn("allow_missing argument is deprecated, use allowmissing instead",
-                     :levels!)
-        allowmissing = allow_missing
-    end
+                 allowmissing::Bool=false) where {T, N, R}
     (levels(A) == newlevels) && return A # nothing to do
 
     # map each new level to its ref code

src/deprecated.jl

@@ -114,19 +114,7 @@ julia> cut(-1:0.5:1, 3, labels=fmt)
 @inline function cut(x::AbstractArray, breaks::AbstractVector;
                      extend::Union{Bool, Missing}=false,
                      labels::Union{AbstractVector{<:SupportedTypes},Function}=default_formatter,
-                     allowmissing::Union{Bool, Nothing}=nothing,
-                     allow_missing::Union{Bool, Nothing}=nothing,
                      allowempty::Bool=false)
-    if allow_missing !== nothing
-        Base.depwarn("allow_missing argument is deprecated, use extend=missing instead",
-                     :cut)
-        extend = missing
-    end
-    if allowmissing !== nothing
-        Base.depwarn("allowmissing argument is deprecated, use extend=missing instead",
-                     :cut)
-         extend = missing
-    end
     return _cut(x, breaks, extend, labels, allowempty)
 end
 

src/extras.jl

@@ -55,9 +55,9 @@ using CategoricalArrays: DefaultRefType, refcode, reftype, leveltype
         @test convert(Union{T, U}, v3)::T == v3
     end
 
-    @test unwrap(v1) === get(v1) === 1
-    @test unwrap(v2) === get(v2) === 2
-    @test unwrap(v3) === get(v3) === 3
+    @test unwrap(v1) === 1
+    @test unwrap(v2) === 2
+    @test unwrap(v3) === 3
 
     @test promote(1, v1) === (1, 1)
     @test promote(1.0, v1) === (1.0, 1.0)

test/05_convert.jl

@@ -719,7 +719,7 @@ using CategoricalArrays: DefaultRefType, leveltype
         @test levels(x) == ["c", "a", "b"]
 
         ordered!(x, ordered)
-        v = CategoricalValue(2, CategoricalPool(["xyz", "b"]))
+        v = CategoricalValue(CategoricalPool(["xyz", "b"]), 2)
         x[1] = v
         @test x[1] === CategoricalValue(x.pool, 4)
         @test x[2] === CategoricalValue(x.pool, 1)

test/11_array.jl

@@ -893,7 +893,7 @@ end
             @test sort(cv, rev=rev, by=byf1) ≅ sort(cv, rev=rev, by=byf1)
 
             # Check that by function is not called on unused levels/missing
-            byf2 = x -> (@assert get(x) != "b"; x)
+            byf2 = x -> (@assert x != "b"; x)
             replace!(cv, missing=>"a", "b"=>"a")
             @test sort(cv, rev=rev, by=byf2) ≅ sort(cv, rev=rev, by=byf2)
         end

test/13_arraycommon.jl

@@ -27,8 +27,7 @@ module TestCategoricalArrays
         "13_arraycommon.jl",
         "14_view.jl",
         "15_extras.jl",
-        "16_recode.jl",
-        "17_deprecated.jl"
+        "16_recode.jl"
     ]
 
     @testset "$test" for test in tests