Fixes problem with DBF file where field name is not padded with \0 (#29)

* Fixes problem with DBF file where rest of field name is not filled with \0

* go directly from bytes until 0 to Symbol

* Omit repetition of hard-coded constant, make variable names more telling

---------

Co-authored-by: Daniel Muschick <[email protected]>
Co-authored-by: Martijn Visser <[email protected]>

Author: 3 people

src/DBFTables.jl

@@ -192,8 +192,12 @@ end
 
 "Read a field descriptor from the stream, and create a FieldDescriptor struct"
 function read_dbf_field(io::IO)
-    field_name_raw = String(read!(io, Vector{UInt8}(undef, 11)))
-    field_name = Symbol(strip(replace(field_name_raw, '\0' => ' ')))
+    n_bytes_field_name = 11 # field name can be up to 11 bytes long, delimited by '\0' (end of string, EOS)
+    field_name_bytes = read(io, n_bytes_field_name)
+    pos_eos = findfirst(iszero, field_name_bytes)
+    n = pos_eos === nothing ? n_bytes_field_name : pos_eos - 1
+    field_name = Symbol(field_name_bytes[1:n])
+
     field_type = read(io, Char)
     skip(io, 4)  # skip
     field_len = read(io, UInt8)