Skip to content

Commit 0d0a463

Browse files
authored
Disable color testing when color is not supported (#2847)
1 parent 47ee7bc commit 0d0a463

File tree

2 files changed

+43
-37
lines changed

2 files changed

+43
-37
lines changed

test/io.jl

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -630,23 +630,26 @@ end
630630
8 │ 8
631631
9 │ 9 #undef"""
632632

633-
io = IOBuffer()
634-
show(IOContext(io, :color => true), df)
635-
str = String(take!(io))
636-
@test str == """
637-
\e[1m9×2 DataFrame\e[0m
638-
\e[1m Row \e[0m│\e[1m A \e[0m\e[1m B \e[0m
639-
\e[1m \e[0m│\e[90m Int64 \e[0m\e[90m Any \e[0m
640-
─────┼──────────────────────────────────────────
641-
1 │ 1 \e[90m 9×2 DataFrame \e[0m
642-
2 │ 2 \e[90m 2-element DataFrameRow \e[0m
643-
3 │ 3 \e[90m 1×2 SubDataFrame \e[0m
644-
4 │ 4 \e[90m 9-element DataFrameRows \e[0m
645-
5 │ 5 \e[90m 2-element DataFrameColumns \e[0m
646-
6 │ 6 \e[90m GroupedDataFrame with 9 groups b… \e[0m
647-
7 │ 7 \e[90m missing \e[0m
648-
8 │ 8 \e[90m \e[0m
649-
9 │ 9 \e[90m #undef \e[0m"""
633+
# TODO: update when https://github.com/KristofferC/Crayons.jl/issues/47 is resolved
634+
if VERSION >= v"1.6" && Base.get_have_color()
635+
io = IOBuffer()
636+
show(IOContext(io, :color => true), df)
637+
str = String(take!(io))
638+
@test str == """
639+
\e[1m9×2 DataFrame\e[0m
640+
\e[1m Row \e[0m│\e[1m A \e[0m\e[1m B \e[0m
641+
\e[1m \e[0m│\e[90m Int64 \e[0m\e[90m Any \e[0m
642+
─────┼──────────────────────────────────────────
643+
1 │ 1 \e[90m 9×2 DataFrame \e[0m
644+
2 │ 2 \e[90m 2-element DataFrameRow \e[0m
645+
3 │ 3 \e[90m 1×2 SubDataFrame \e[0m
646+
4 │ 4 \e[90m 9-element DataFrameRows \e[0m
647+
5 │ 5 \e[90m 2-element DataFrameColumns \e[0m
648+
6 │ 6 \e[90m GroupedDataFrame with 9 groups b… \e[0m
649+
7 │ 7 \e[90m missing \e[0m
650+
8 │ 8 \e[90m \e[0m
651+
9 │ 9 \e[90m #undef \e[0m"""
652+
end
650653

651654
io = IOBuffer()
652655
show(io, MIME("text/html"), df)

test/show.jl

Lines changed: 23 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -215,26 +215,29 @@ end
215215
end
216216

217217
@testset "Test colors and non-standard values: missing and nothing" begin
218-
df = DataFrame(Fish = ["Suzy", "Amir"], Mass = [1.5, missing])
219-
@test sprint(show, df, context=:color=>true) == """
220-
\e[1m2×2 DataFrame\e[0m
221-
\e[1m Row \e[0m│\e[1m Fish \e[0m\e[1m Mass \e[0m
222-
\e[1m \e[0m│\e[90m String \e[0m\e[90m Float64? \e[0m
223-
─────┼───────────────────
224-
1 │ Suzy 1.5
225-
2 │ Amir \e[90m missing \e[0m"""
226-
227-
df = DataFrame(A = [:Symbol, missing, :missing],
228-
B = [missing, "String", "missing"],
229-
C = [:missing, "missing", missing])
230-
@test sprint(show, df, context=:color=>true) == """
231-
\e[1m3×3 DataFrame\e[0m
232-
\e[1m Row \e[0m│\e[1m A \e[0m\e[1m B \e[0m\e[1m C \e[0m
233-
\e[1m \e[0m│\e[90m Symbol? \e[0m\e[90m String? \e[0m\e[90m Any \e[0m
234-
─────┼───────────────────────────
235-
1 │ Symbol \e[90m missing \e[0m missing
236-
2 │\e[90m missing \e[0m String missing
237-
3 │ missing missing \e[90m missing \e[0m"""
218+
# TODO: update when https://github.com/KristofferC/Crayons.jl/issues/47 is resolved
219+
if VERSION >= v"1.6" && Base.get_have_color()
220+
df = DataFrame(Fish = ["Suzy", "Amir"], Mass = [1.5, missing])
221+
@test sprint(show, df, context=:color=>true) == """
222+
\e[1m2×2 DataFrame\e[0m
223+
\e[1m Row \e[0m│\e[1m Fish \e[0m\e[1m Mass \e[0m
224+
\e[1m \e[0m│\e[90m String \e[0m\e[90m Float64? \e[0m
225+
─────┼───────────────────
226+
1 │ Suzy 1.5
227+
2 │ Amir \e[90m missing \e[0m"""
228+
229+
df = DataFrame(A = [:Symbol, missing, :missing],
230+
B = [missing, "String", "missing"],
231+
C = [:missing, "missing", missing])
232+
@test sprint(show, df, context=:color=>true) == """
233+
\e[1m3×3 DataFrame\e[0m
234+
\e[1m Row \e[0m│\e[1m A \e[0m\e[1m B \e[0m\e[1m C \e[0m
235+
\e[1m \e[0m│\e[90m Symbol? \e[0m\e[90m String? \e[0m\e[90m Any \e[0m
236+
─────┼───────────────────────────
237+
1 │ Symbol \e[90m missing \e[0m missing
238+
2 │\e[90m missing \e[0m String missing
239+
3 │ missing missing \e[90m missing \e[0m"""
240+
end
238241

239242
df_nothing = DataFrame(A = [1.0, 2.0, 3.0], B = ["g", "g", nothing])
240243
@test sprint(show, df_nothing) == """

0 commit comments

Comments
 (0)