Skip to content

Commit cae78ce

Browse files
authored
Reduce memory use in threading correctness tests (#3172)
1 parent ed41652 commit cae78ce

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

test/indexing.jl

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2023,15 +2023,13 @@ include("indexing_offset.jl")
20232023

20242024
@testset "threading correctness tests" begin
20252025
for x in (10, 1_100_000), y in 1:4
2026-
mat = rand(Int8, x, y)
2027-
df = DataFrame(mat, :auto)
2026+
vecvec = [rand(Int8, x) for _ in 1:y]
2027+
df = DataFrame(vecvec, :auto, copycols=false)
20282028
for rowrange in [:, 1:nrow(df)-5, collect(1:nrow(df)-5), axes(df, 1) .< nrow(df)-5],
20292029
colrange in [:, axes(df, 2), collect(axes(df, 2)), 1:ncol(df) - 1]
2030-
# Equivalent but using less memory than:
2031-
# @test DataFrame(mat[rowrange, colrange], :auto) == df[rowrange, colrange]
20322030
df2 = df[rowrange, colrange]
20332031
for j in axes(df2, 2)
2034-
@test df2[!, j] == view(mat, rowrange, j)
2032+
@test df2[!, j] == view(vecvec[j], rowrange)
20352033
end
20362034
end
20372035
end

0 commit comments

Comments
 (0)