Fix eltype handling in output_arrays and add test for RGB pyramid

Author: felixcremer

src/PyramidScheme.jl

@@ -280,7 +280,6 @@ If the array is smaller than 10e6 it is created on disk and otherwise as a tempo
 function gen_output(t,s; path=tempname())
     # This should be dispatching on the output type whether it is internal or external
     outsize = sizeof(t)*prod(s)
-    z = Zeros(t, s...)
     if outsize > 100e6
         # This should be zgroup instead of zcreate, could use savedataset(skelton=true)
         # Dummy dataset with FillArrays with the shape of the pyramidlevel
@@ -383,8 +382,8 @@ function getpyramids(reducefunc, ras;recursive=true)
     end 
     pyramid_sizes =  [ceil.(Int, size(ras) ./ 2^i) for i in 1:n_level]
     pyramid_axes = [agg_axis.(input_axes,2^i) for i in 1:n_level]
-
-    outmin = output_arrays(pyramid_sizes, Float32)
+    outtype = typeof(reducefunc(rand(eltype(ras),2,2)))
+    outmin = output_arrays(pyramid_sizes, outtype)
     fill_pyramids(ras,outmin,reducefunc,recursive; threaded=true)
 
     outmin, pyramid_axes

test/runtests.jl

@@ -43,6 +43,17 @@ end
     @test parent(subpyramid) == data[1:10,1:10]
     fig, axis, h = plot(pyramid)
 end
+
+@testitem "Pyramid building RGB eltype" begin
+    using PyramidScheme: PyramidScheme as PS
+    using Colors
+    data = rand(RGB, 2000,2000)
+    dd = DimArray(data, (X(1:2000), Y(1:2000)))
+    pyramid = PS.Pyramid(dd)
+
+
+end
+
 @testitem "Helper functions" begin
     using PyramidScheme: PyramidScheme as PS
     @test PS.compute_nlevels(zeros(1000)) == 2
@@ -107,6 +118,7 @@ end
 
 end
 
+
 #=
 @testitem "Comparing zarr pyramid with tif pyramid" begin
     using PyramidScheme: PyramidScheme as PS