Implementing broadcast using Flatten #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
+ Coverage 66.28% 74.52% +8.23%
==========================================
Files 3 4 +1
Lines 264 420 +156
==========================================
+ Hits 175 313 +138
- Misses 89 107 +18 ☔ View full report in Codecov by Sentry. |
This enables to use broadcasting with scalars as well. It will error on AbstractArrays to hint, that the array should be converted to a Pyramid before. Co-authored-by: Rafael Schouten <[email protected]>
felixcremer
force-pushed
the
fc/update
branch
from
e36434d to
1b9a9a3
Compare
We can enable them later on main, when we have the interface to add the maximal size of the coarsest level, so that the depth of the pyramid is the same from in memory and from gdal.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should enable to use PS with the latest Raster and YAXArrays versions.