Skip to content

Conversation

@meggart
Copy link
Member

@meggart meggart commented Sep 10, 2025

This allows additional dimensions to exist when building a pyramid. I just got an example working where I built a DGGS pyramid, that had an addtional n dimension.

TODO:

  • add a test
  • somehow allow to pass chunk information to the output array creation

@felixcremer
Copy link
Member

We should copy the test from #42.

@felixcremer
Copy link
Member

This should also be the same behaviour for an in-memory built Pyramid and a on disk Zarr Pyramid via buildpyramids.
I am wondering whether we could streamline these two code paths to overlap a bit more.

@felixcremer
Copy link
Member

The nightly failure is due to JuliaConcurrent/ConcurrentCollections.jl#66

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.17%. Comparing base (85be5d9) to head (bcee212).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   71.42%   72.17%   +0.74%     
==========================================
  Files           4        4              
  Lines         308      327      +19     
==========================================
+ Hits          220      236      +16     
- Misses         88       91       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@felixcremer felixcremer merged commit 9374288 into main Nov 5, 2025
6 of 8 checks passed
@felixcremer felixcremer deleted the fg/multidim branch November 5, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants