Fix Makie recipe

[asinghvi17]

Make it work but remove colorbar

I have an idea for a semi official hack that can bring it back though

[asinghvi17]

Here is the error message, cc @ffreyer:

julia> fig, axis, h = plot(pyramid)
Error showing value of type Makie.FigureAxisPlot:

SYSTEM (REPL): showing an error caused an error
ERROR: 1-element ExceptionStack:
Failed to resolve gl_renderobject:
[ComputeEdge] gl_renderobject = #register_robj!##0((x_transformed_f32c, y_transformed_f32c, space, alpha_colormap, scaled_color, scaled_colorrange, lowclip_color, highclip_color, nan_color, model_f32c, instances, uniform_clip_planes, uniform_num_clip_planes, depth_shift, visible, fxaa, resolution, projection, projectionview, view, upvector, eyeposition, view_direction, ), changed, cached)
  @ /Users/anshul/.julia/packages/GLMakie/6el3D/src/plot-primitives.jl:238
[ComputeEdge] x_transformed_f32c, y_transformed_f32c = #add_computation!##6((x_transformed, y_transformed, model, f32c, space, ), changed, cached)
  @ /Users/anshul/.julia/packages/Makie/4JW9B/src/backend-functionality.jl:70
[ComputeEdge] x_transformed, y_transformed = (::MapFunctionWrapper(#add_computation!##4))((x, y, image, transform_func, ), changed, cached)
  @ unknown method location
[ComputeEdge] x, y, image = (::MapFunctionWrapper(#_register_argument_conversions!##8))((converted, ), changed, cached)
  @ /Users/anshul/.julia/packages/Makie/4JW9B/src/compute-plots.jl:514
[ComputeEdge] converted = (::MapFunctionWrapper(#_register_argument_conversions!##6))((dim_converted, convert_kwargs, ), changed, cached)
  @ unknown method location
[ComputeEdge] dim_converted = (::MapFunctionWrapper(#_register_argument_conversions!##2))((args, ), changed, cached)
  @ /Users/anshul/.julia/packages/Makie/4JW9B/src/compute-plots.jl:483
[ComputeEdge] args = (::MapFunctionWrapper(#_register_expand_arguments!##2))((arg1, ), changed, cached)
  @ /Users/anshul/.julia/packages/Makie/4JW9B/src/compute-plots.jl:407
[ComputeEdge] arg1 = compute_identity((pyramid_sampled_data, ), changed, cached)
  @ /Users/anshul/.julia/packages/ComputePipeline/03tW7/src/ComputePipeline.jl:737
  with edge inputs:
    pyramid_sampled_data = [0.4657400790793546 0.510134871178912 … 0.4328763134067525 0.4572599045051609; 0.4565548691275807 0.47804763577524106 … 0.4695851929962584 0.4687884421200218; … ; 0.4110936171223971 0.5469050186653079 … 0.5094944834568137 0.4864871965602684; 0.43386027796617677 0.5778999814287546 … 0.5103769765607518 0.4819549699466726]
Triggered by update of:
  arg1, view, projection, viewport, space, __pyramid_input_positions, viewport or __pyramid_input_positions
Due to ERROR: MethodError: Cannot `convert` an object of type 
[...] (not relevant, but the types have some different parameters)

and the stacktrace:

Stacktrace:
  [1] setproperty!(x::Base.RefValue{…}, f::Symbol, v::DimMatrix{…})
    @ Base ./Base_compiler.jl:57
  [2] setindex!(b::Base.RefValue{…}, x::DimMatrix{…})
    @ Base ./refvalue.jl:60
  [3] set_result!(edge::ComputePipeline.TypedEdge{…}, result::Tuple{}, i::Int64, value::DimMatrix{…})
    @ ComputePipeline ~/.julia/packages/ComputePipeline/03tW7/src/ComputePipeline.jl:586
  [4] set_result!(edge::ComputePipeline.TypedEdge{…}, result::Tuple{…})
    @ ComputePipeline ~/.julia/packages/ComputePipeline/03tW7/src/ComputePipeline.jl:599
  [5] resolve!(edge::ComputePipeline.TypedEdge{@NamedTuple{…}, Tuple{…}, typeof(ComputePipeline.compute_identity)})
    @ ComputePipeline ~/.julia/packages/ComputePipeline/03tW7/src/ComputePipeline.jl:632
  [6] (::ComputePipeline.var"#resolve!##4#resolve!##5"{ComputePipeline.ComputeEdge{ComputePipeline.ComputeGraph}})()
    @ ComputePipeline ~/.julia/packages/ComputePipeline/03tW7/src/ComputePipeline.jl:666
  [7] lock(f::ComputePipeline.var"#resolve!##4#resolve!##5"{ComputePipeline.ComputeEdge{…}}, l::ReentrantLock)
    @ Base ./lock.jl:335
  [8] resolve!(edge::ComputePipeline.ComputeEdge{ComputePipeline.ComputeGraph})
    @ ComputePipeline ~/.julia/packages/ComputePipeline/03tW7/src/ComputePipeline.jl:659
  [9] _resolve!(computed::ComputePipeline.Computed)
    @ ComputePipeline ~/.julia/packages/ComputePipeline/03tW7/src/ComputePipeline.jl:652
 [10] foreach
    @ ./abstractarray.jl:3188 [inlined]
 [11] (::ComputePipeline.var"#resolve!##4#resolve!##5"{ComputePipeline.ComputeEdge{ComputePipeline.ComputeGraph}})()
    @ ComputePipeline ~/.julia/packages/ComputePipeline/03tW7/src/ComputePipeline.jl:661
--- the above 5 lines are repeated 6 more times ---
 [42] lock(f::ComputePipeline.var"#resolve!##4#resolve!##5"{ComputePipeline.ComputeEdge{…}}, l::ReentrantLock)
    @ Base ./lock.jl:335
 [43] resolve!(edge::ComputePipeline.ComputeEdge{ComputePipeline.ComputeGraph})
    @ ComputePipeline ~/.julia/packages/ComputePipeline/03tW7/src/ComputePipeline.jl:659
 [44] _resolve!(computed::ComputePipeline.Computed)
    @ ComputePipeline ~/.julia/packages/ComputePipeline/03tW7/src/ComputePipeline.jl:652
 [45] resolve!(computed::ComputePipeline.Computed)
    @ ComputePipeline ~/.julia/packages/ComputePipeline/03tW7/src/ComputePipeline.jl:644
 [46] getindex
    @ ~/.julia/packages/ComputePipeline/03tW7/src/ComputePipeline.jl:563 [inlined]
 [47] register_robj!(constructor!::Function, screen::GLMakie.Screen{…}, scene::Scene, plot::Heatmap{…}, inputs::Vector{…}, uniforms::Vector{…}, input2glname::Dict{…})
    @ GLMakie ~/.julia/packages/GLMakie/6el3D/src/plot-primitives.jl:252

[codecov]

Codecov Report

❌ Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.51%. Comparing base (6e07cf0) to head (383ce60).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
ext/PyramidSchemeMakieExt.jl	89.18%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   70.66%   70.51%   -0.16%     
==========================================
  Files           4        4              
  Lines         300      312      +12     
==========================================
+ Hits          212      220       +8     
- Misses         88       92       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[felixcremer]

I have tested printing inside the readblock! of Zarr.jl and the pyramid getindex via intervals runs through a DimensionalData dispatch into a reading of every level of the pyramid while the getindex on the levels would run through getindex(YAXArray, inds) into a view of the data.

[felixcremer]

I don't understand why these lines are not hit by tests when we had to fix these lines to make the plot! run.

[felixcremer]

The nightly failure is from precompiling and this error message:
WARNING: Imported binding Threads.inttypes was undeclared at import time during import to UnsafeAtomics.