Skip to content

Commit 9609dee

Browse files
authored
Merge pull request #300 from JuliaDatabases/ed/jq-dbinterface
Rebase of #289
2 parents 9eca383 + 9ed0a0a commit 9609dee

File tree

2 files changed

+27
-7
lines changed

2 files changed

+27
-7
lines changed

src/dbinterface.jl

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,29 @@
1-
DBInterface.connect(::Type{Connection}, args...; kws...) = Connection(args...; kws...)
1+
struct DBConnection <: DBInterface.Connection
2+
conn::Connection
3+
end
4+
5+
function DBInterface.connect(::Type{Connection}, args...; kwargs...)
6+
return DBConnection(Connection(args...; kwargs...))
7+
end
8+
9+
function DBInterface.prepare(conn::DBConnection, args...; kwargs...)
10+
return prepare(conn.conn, args...; kwargs...)
11+
end
212

3-
DBInterface.prepare(conn::Connection, args...; kws...) = prepare(conn, args...; kws...)
13+
function DBInterface.execute(conn::DBConnection, args...; kwargs...)
14+
return execute(conn.conn, args...; kwargs...)
15+
end
16+
17+
function DBInterface.execute(conn::DBConnection, str::AbstractString; kwargs...)
18+
return execute(conn.conn, str; kwargs...)
19+
end
20+
21+
function DBInterface.execute(conn::DBConnection, str::AbstractString, params; kwargs...)
22+
return execute(conn.conn, str, params; kwargs...)
23+
end
424

5-
function DBInterface.execute(conn::Union{Connection,Statement}, args...; kws...)
6-
return execute(conn, args...; kws...)
25+
function DBInterface.execute(stmt::Statement, args...; kwargs...)
26+
return execute(stmt, args...; kwargs...)
727
end
828

9-
DBInterface.close!(conn::Connection) = close(conn)
29+
DBInterface.close!(conn::DBConnection) = close(conn.conn)

test/runtests.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1912,7 +1912,7 @@ end
19121912

19131913
@testset "DBInterface integration" begin
19141914
conn = DBInterface.connect(LibPQ.Connection, "dbname=postgres user=$DATABASE_USER")
1915-
@test conn isa LibPQ.Connection
1915+
@test conn isa LibPQ.DBConnection
19161916

19171917
result = DBInterface.execute(
19181918
conn,
@@ -1944,7 +1944,7 @@ end
19441944
@test LibPQ.column_name(result, 2) == "typname"
19451945

19461946
DBInterface.close!(conn)
1947-
@test !isopen(conn)
1947+
@test !isopen(conn.conn)
19481948

19491949
end
19501950
end

0 commit comments

Comments
 (0)