Fix tests for inverted linetable #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaLang/julia#52415 introduced a fundamental change in how line information is encoded. Because this package delves into internals, there were a couple tests that failed on Julia 1.12+. This adds a utility, `CodeTracking.linetable_scopes`, that makes it easier to work with the new representation across Julia versions.
aviatesk
approved these changes
Mar 17, 2025
Member
Author
|
The only failures are in Revise. I'll leave this open a bit while I explore whether it actually helps fix JuliaInterpreter bugs. |
aviatesk
approved these changes
Apr 2, 2025
Member
Author
|
I'll go ahead and merge this, but maybe hold off on tagging a new release to be sure we won't want more changes in representation. I still haven't gotten to a major need for it yet in JuliaInterpreter, but it seems like something that will likely be useful somewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JuliaLang/julia#52415 introduced a fundamental
change in how line information is encoded. Because this package delves
into internals, there were a couple tests that failed on Julia 1.12+.
This adds a utility,
CodeTracking.linetable_scopes, that makes iteasier to work with the new representation across Julia versions.
This may be useful in fixing some JuliaInterpreter issues.
CC @aviatesk, @vtjnash