Some printing fixes (#306)

* do not try to syntax highlight files with non julia extensions

* stop falling back to lowered code when CodeTracking cant find the method start

we can instead just set `defline = 0` and thereby have an "unknown" method start while still showing the source code

Author: KristofferC

src/locationinfo.jl

@@ -7,18 +7,23 @@ function locinfo(frame::Frame)
         ret = JuliaInterpreter.whereis(frame)
         ret === nothing && return nothing
         current_file, current_line = ret
+        body_defline = CodeTracking.definition(String, meth)
         local body, defline
-        try # https://github.com/timholy/CodeTracking.jl/issues/31
-            body, defline = CodeTracking.definition(String, meth)
-        catch
-            return nothing
+        unknown_start = false
+        if body_defline === nothing
+            unknown_start = true
+        else
+            body, defline = body_defline
+            if deffile != current_file || defline > current_line
+                unknown_start = true
+            end
         end
-        if deffile != current_file || defline > current_line
+        if unknown_start
             isfile(current_file) || return nothing
             body = read(current_file, String)
             defline = 0 # We are not sure where the context start in cases like these, could be improved?
         end
-        return defline, current_line, body
+        return defline, deffile, current_line, body
     else
         println("not yet implemented")
     end
@@ -88,4 +93,4 @@ function locdesc(io, frame::Frame; current_line=false)
     path = string(_print_full_path[] ? meth.file : basename(String(meth.file)), ":", line)
     path = CodeTracking.replace_buildbot_stdlibpath(String(path))
     print(io, ") at ", path)
-end
+end

src/printing.jl

@@ -134,9 +134,9 @@ function print_status(io::IO, frame::Frame; force_lowered=false)
     loc = locinfo(frame)
 
     if loc !== nothing && !force_lowered
-        defline, current_line, body = loc
+        defline, deffile, current_line, body = loc
         breakpoint_lines = breakpoint_linenumbers(frame)
-        ok = print_sourcecode(outbuf, body, current_line, defline, breakpoint_lines)
+        ok = print_sourcecode(outbuf, body, current_line, defline, deffile, breakpoint_lines)
         if !ok
             printstyled(io, "failed to lookup source code, showing lowered code:\n"; color=Base.warn_color())
             print_codeinfo(outbuf, frame)
@@ -240,8 +240,11 @@ function breakpoint_char(bp::BreakpointState)
     return bp.condition === JuliaInterpreter.falsecondition ? ' ' : '○'
 end
 
-function print_sourcecode(io::IO, code::AbstractString, current_line::Integer, defline::Integer, breakpoint_lines::Dict{Int, BreakpointState} = Dict{Int, BreakpointState}())
-    code = highlight_code(code; context=io)
+function print_sourcecode(io::IO, code::AbstractString, current_line::Integer, defline::Integer, deffile::AbstractString, breakpoint_lines::Dict{Int, BreakpointState} = Dict{Int, BreakpointState}())
+    _, ext = splitext(deffile)
+    if isempty(ext) || ext == ".jl"
+        code = highlight_code(code; context=io)
+    end
     file = SourceFile(code)
     current_offsetline = current_line - defline + 1
     checkbounds(Bool, file.offsets, current_offsetline) || return false

test/misc.jl

@@ -56,7 +56,7 @@ end
 frame = Debugger.@make_frame f()
 state = dummy_state(frame)
 execute_command(state, Val{:n}(), "n")
-defline, current_line, body = Debugger.locinfo(state.frame)
+defline, deffile, current_line, body = Debugger.locinfo(state.frame)
 @test occursin("handle_message(logger, level", body)
 
 f_unicode() = √