Don't construct Module() during precompilation#134
Merged
pfitzseb merged 1 commit intoJuliaDebug:masterfrom Feb 18, 2025
Merged
Don't construct Module() during precompilation#134pfitzseb merged 1 commit intoJuliaDebug:masterfrom
Module() during precompilation#134pfitzseb merged 1 commit intoJuliaDebug:masterfrom
Conversation
pfitzseb
approved these changes
Feb 18, 2025
Member
|
Anyone package that loads this package will still hit this due to the |
Contributor
Author
|
Would you have an error log to share? This PR fixed an issue during precompilation, not during |
Member
|
Other packages that load this will run this package |
Contributor
Author
|
I see, will make a PR |
Member
|
Imo JuliaLang/julia#57635 should be fixed |
Contributor
Author
|
That'd be nice, as I expect many other packages to rely on this. In the meantime, here is #136 which I'd be happy to revert at some point in the future if the situation is resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new error appeared for
nightly, likely due to JuliaLang/julia#57425:The created
Module()was anyway discarded withclear_store!(store)during__init__(), so this change should be safe.