Try harder to find llvmcalls

One can use `llvmcall` without scoping it as `Base.llvmcall`. Thus we
need a reliable way to find it independently of the GlobalRef module.

Author: timholy

src/construct.jl

@@ -166,8 +166,8 @@ function prepare_framecode(method::Method, @nospecialize(argtypes); enter_genera
         # Currenly, our strategy to deal with llvmcall can't handle parametric functions
         # (the "mini interpreter" runs in module scope, not method scope)
         if (!isempty(lenv) && (hasarg(isidentical(:llvmcall), code.code) ||
-                               hasarg(isidentical(Base.llvmcall), code.code) ||
-                               hasarg(a->is_global_ref(a, Base, :llvmcall), code.code))) ||
+                               hasarg(isidentical(Core.Intrinsics.llvmcall), code.code) ||
+                               hasarg(a->is_global_ref_egal(a, :llvmcall, Core.Intrinsics.llvmcall), code.code))) ||
                                hasarg(isidentical(:iolock_begin), code.code)
             return Compiled()
         end

src/optimize.jl

@@ -131,7 +131,7 @@ function optimize!(code::CodeInfo, scope)
                 # Check for :llvmcall
                 arg1 = stmt.args[1]
                 larg1 = lookup_stmt(code.code, arg1)
-                if (arg1 === :llvmcall || larg1 === Base.llvmcall || is_global_ref(larg1, Base, :llvmcall)) && isempty(sparams) && scope isa Method
+                if (arg1 === :llvmcall || larg1 === Base.llvmcall || is_global_ref_egal(larg1, :llvmcall, Core.Intrinsics.llvmcall)) && isempty(sparams) && scope isa Method
                     # Call via `invokelatest` to avoid compiling it until we need it
                     @invokelatest build_compiled_llvmcall!(stmt, code, idx, evalmod)
                     methodtables[idx] = Compiled()

src/utils.jl

@@ -140,6 +140,14 @@ Tests whether `g` is equal to `GlobalRef(mod, name)`.
 """
 is_global_ref(@nospecialize(g), mod::Module, name::Symbol) = isa(g, GlobalRef) && g.mod === mod && g.name == name
 
+function is_global_ref_egal(@nospecialize(g), name::Symbol, @nospecialize(ref))
+    # Identifying GlobalRefs regardless of how the caller scopes them
+    isa(g, GlobalRef) || return false
+    g.name === name || return false
+    gref = getglobal(g.mod, g.name)
+    return gref === ref
+end
+
 is_quotenode(@nospecialize(q), @nospecialize(val)) = isa(q, QuoteNode) && q.value == val
 is_quotenode_egal(@nospecialize(q), @nospecialize(val)) = isa(q, QuoteNode) && q.value === val