Skip to content

Commit 3b14198

Browse files
authored
check_builtins only via the action on CI (#695)
Currently `1.12-nightly` is failing `check_builtins` due to the absence of `Core._import`. While `check_builtins` doesn't do anything unless `!Base.GIT_VERSION_INFO.tagged_commit`, both `nightly` and `1.12-rc1` satisfy this condition. Since we have a separate action to run this test on CI only on nightly, we can skip running it from `runtests.jl` if `ENV["GITHUB_ACTION"]` is set.
1 parent e66fa6d commit 3b14198

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

test/check_builtins.jl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
using Test, DeepDiffs
22

3-
@static if !Base.GIT_VERSION_INFO.tagged_commit && # only run on nightly
4-
!Sys.iswindows() # TODO: Understand why this fails, probably some line endings
3+
@static if get(ENV, "GITHUB_ACTION", nothing) === nothing && # on CI we have a separate action to run this test
4+
!Base.GIT_VERSION_INFO.tagged_commit && # only run on nightly
5+
!Sys.iswindows() # TODO: Understand why this fails, probably some line endings
56
@testset "Check builtin.jl consistency" begin
67
builtins_path = joinpath(@__DIR__, "..", "src", "builtins.jl")
78
old_builtins = read(builtins_path, String)

0 commit comments

Comments
 (0)