Skip to content

Conversation

@JamesWrigley
Copy link
Contributor

This helps type-stability and prevents invalidations. Specifically, it prevents these invalidations on Julia 1.12 with UnsafePointers.jl (CC @cjdoris):

 inserting getindex(p::UnsafePointers.UnsafePtr{T}) where T @ UnsafePointers ~/git/UnsafePointers.jl/src/UnsafePointers.jl:105 invalidated:
   mt_backedges: 1: signature Tuple{typeof(getindex), Ref{Bool}} triggered MethodInstance for JuliaInterpreter.add_breakpoint_if_match!(::JuliaInterpreter.FrameCode, ::JuliaInterpreter.BreakpointSignature) (1 children)
                 2: signature Tuple{typeof(getindex), Ref{Bool}} triggered MethodInstance for JuliaInterpreter.add_breakpoint_if_match!(::JuliaInterpreter.FrameCode, ::JuliaInterpreter.BreakpointFileLocation) (273 children)

This helps type-stability and prevents invalidations.
@codecov
Copy link

codecov bot commented Oct 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.81%. Comparing base (376d172) to head (f3a16cd).
⚠️ Report is 80 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
+ Coverage   81.03%   84.81%   +3.78%     
==========================================
  Files          12       12              
  Lines        2636     2726      +90     
==========================================
+ Hits         2136     2312     +176     
+ Misses        500      414      -86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aviatesk aviatesk merged commit f20937e into JuliaDebug:master Oct 18, 2025
10 of 11 checks passed
@aviatesk
Copy link
Member

Thanks for your contribution!

@JamesWrigley JamesWrigley deleted the refvalue branch October 18, 2025 17:24
@JamesWrigley
Copy link
Contributor Author

Would it be possible to tag a new release with this?

@aviatesk
Copy link
Member

Tagged a new release.

@JamesWrigley
Copy link
Contributor Author

Thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants