Skip to content

Commit 7738b80

Browse files
authored
enrich test suite a bit more (#82)
1 parent 3f95258 commit 7738b80

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

.github/workflows/CI.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ jobs:
1515
version:
1616
- '1.6' # current LTS
1717
- '1' # latest stable
18+
- '1.10-nightly' # next stable
1819
- 'nightly'
1920
os:
2021
- ubuntu-latest

test/codeedges.jl

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,12 +97,13 @@ module ModSelective end
9797
y2 = 7
9898
a2 = 2
9999
end
100+
a2
100101
end
101102
frame = Frame(ModSelective, ex)
102103
src = frame.framecode.src
103104
edges = CodeEdges(src)
104105
isrequired = lines_required(:a2, src, edges)
105-
selective_eval_fromstart!(frame, isrequired)
106+
selective_eval_fromstart!(frame, isrequired, #=istoplevel=#true)
106107
Core.eval(ModEval, ex)
107108
@test ModSelective.a2 === ModEval.a2 == 1
108109
@test allmissing(ModSelective, (:z2, :x2, :y2))
@@ -294,7 +295,7 @@ module ModSelective end
294295
# https://github.com/timholy/Revise.jl/issues/538
295296
thk = Meta.lower(ModEval, quote
296297
try
297-
global function v1(x::Float32)
298+
global function revise538(x::Float32)
298299
println("F32")
299300
end
300301
catch e
@@ -303,9 +304,9 @@ module ModSelective end
303304
end)
304305
src = thk.args[1]
305306
edges = CodeEdges(src)
306-
lr = lines_required(:v1, src, edges)
307-
idx = findfirst(stmt->Meta.isexpr(stmt, :leave), src.code)
308-
@test lr[idx]
307+
lr = lines_required(:revise538, src, edges)
308+
selective_eval_fromstart!(Frame(ModEval, src), lr, #=istoplevel=#true)
309+
@test isdefined(ModEval, :revise538) && length(methods(ModEval.revise538, (Float32,))) == 1
309310

310311
# https://github.com/timholy/Revise.jl/issues/599
311312
thk = Meta.lower(Main, quote
@@ -426,7 +427,7 @@ end
426427

427428
isrq = lines_required!(istypedef.(stmts), src, edges)
428429
frame = Frame(m, src)
429-
selective_eval_fromstart!(frame, isrq, #= toplevel =# true)
430+
selective_eval_fromstart!(frame, isrq, #=toplevel=#true)
430431

431432
for def in defs; @test isdefined(m, def); end
432433
for undef in undefs; @test !isdefined(m, undef); end

0 commit comments

Comments
 (0)