follow up #66, allow method definition in other module (#67)

I found JuliaInterpreter can define a method even if its module isn't
same as `moduleof(frame::Frame)`.

Author: aviatesk

src/signatures.jl

@@ -154,7 +154,6 @@ function identify_framemethod_calls(frame)
         elseif ismethod1(stmt)
             key = stmt.args[1]
             key = normalize_defsig(key, frame)
-            key === missing && continue
             key = key::Symbol
             mi = get(methodinfos, key, nothing)
             if mi === nothing
@@ -165,7 +164,6 @@ function identify_framemethod_calls(frame)
         elseif ismethod3(stmt)
             key = stmt.args[1]
             key = normalize_defsig(key, frame)
-            key === missing && continue
             if key isa Symbol
                 mi = methodinfos[key]
                 mi.stop = i
@@ -216,10 +214,8 @@ end
 # try to normalize `def` to `Symbol` representation
 function normalize_defsig(@nospecialize(def), frame::Frame)
     if def isa QuoteNode
-        parentmodule(def.value) === moduleof(frame) || return false
         def = nameof(def.value)
     elseif def isa GlobalRef
-        def.mod === moduleof(frame) || return false
         def = def.name
     end
     return def

test/signatures.jl

@@ -443,7 +443,7 @@ using LoweredCodeUtils, JuliaInterpreter, Test
 macro deffoogr()
     gr = GlobalRef(__module__, :foogr) # will be lowered to `GlobalRef`
     quote
-        $gr(args...) = length(args) + 2
+        $gr(args...) = length(args)
     end
 end
 let
@@ -469,4 +469,35 @@ let
     @test haskey(methranges, :fooqn)
 end
 
+# define methods in other module
+module sandboxgr end
+macro deffoogr_sandbox()
+    gr = GlobalRef(sandboxgr, :foogr_sandbox) # will be lowered to `GlobalRef`
+    quote
+        $gr(args...) = length(args)
+    end
+end
+let
+    ex = quote
+        @deffoogr_sandbox
+        @show sandboxgr.foogr_sandbox(1,2,3)
+    end
+    methranges = rename_framemethods!(Frame(@__MODULE__, ex))
+    @test haskey(methranges, :foogr_sandbox)
+end
+
+module sandboxqn; function fooqn_sandbox end; end
+macro deffooqn_sandbox()
+    sig = :($(GlobalRef(sandboxqn, :fooqn_sandbox))(args...)) # will be lowered to `QuoteNode`
+    return Expr(:function, sig, Expr(:block, __source__, :(length(args))))
+end
+let
+    ex = quote
+        @deffooqn_sandbox
+        @show sandboxqn.fooqn_sandbox(1,2,3)
+    end
+    methranges = rename_framemethods!(Frame(@__MODULE__, ex))
+    @test haskey(methranges, :fooqn_sandbox)
+end
+
 end