adjustments to v1.12 #124
adjustments to v1.12 #124
Conversation
There have been changes to type definitions and global variable assignments to v1.12, and this commit tries to adjust the code base to it. There might be some missing pieces still, this allow us to reduce the failures in the test suite.
|
That was a really tough job, but it seems to be working now. |
On recent Julia versions we can just pattern match against `:method` expressions.
|
Here are the key points of this change:
This change is necessary to update JET to Julia 1.12, so I'm going to proceed with merging it. I welcome review comments even after it's merged. |
|
Just a heads up that this broke Revise: timholy/Revise.jl#906. Looks like |
timholy
left a comment
timholy
left a comment
There was a problem hiding this comment.
Sorry I didn't notice this, and thanks for the update! I agree these 1.12 updates are significant effort.
Looks like we'll need to adjust a couple of items to fix timholy/Revise.jl#906, I'll add those separately.
| end | ||
| end | ||
| elseif stmt.head !== :copyast | ||
| stmt = stmt::Expr |
There was a problem hiding this comment.
This line seems like it must date to an era when inference was not as capable, though obviously it does no harm.
| isrequired[p] && continue | ||
| isrequired[p] = true | ||
| chngd = true | ||
| end |
There was a problem hiding this comment.
Oh interesting, I assume this was a bugfix?
There have been changes to type definitions and global variable assignments to v1.12, and this commit tries to adjust the code base to it. There might be some missing pieces still, this allow us to reduce the failures in the test suite.