Skip to content

Conversation

@serenity4
Copy link
Collaborator

Otherwise, Base.IRShow methods end up requiring Base.Compiler types, which will be incompatible with any non-fallback Compiler implementation.

@serenity4 serenity4 requested a review from aviatesk July 8, 2025 13:55
@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.86%. Comparing base (550a2a4) to head (73b5d3f).
Report is 44 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #132       +/-   ##
===========================================
- Coverage   88.69%   76.86%   -11.83%     
===========================================
  Files           6        6               
  Lines        1442     1526       +84     
===========================================
- Hits         1279     1173      -106     
- Misses        163      353      +190     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +14 to +18
@static if isdefined(CC, :IRShow)
using .CC: IRShow
else
using Base: IRShow
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just use CC.IRShow now? CC.IRShow === Base.IRShow when CC === Base.Compiler.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so as well, but AFAIK pre-1.11 (before making Compiler its own package) IRShow was defined in Base but not in Compiler.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Let's move as is then.

@aviatesk aviatesk merged commit 3c261b3 into JuliaDebug:master Jul 9, 2025
9 of 10 checks passed
serenity4 added a commit to serenity4/LoweredCodeUtils.jl that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants