fixes

Author: mcabbott

src/projection.jl

@@ -229,24 +229,22 @@ end
 # Note that while [1 2; 3 4]' isa Adjoint, we use ProjectTo{Adjoint} only to encode AdjointAbsVec.
 # Transposed matrices are, like PermutedDimsArray, just a storage detail,
 # but row vectors behave differently, for example [1,2,3]' * [1,2,3] isa Number
-(project::ProjectTo{Adjoint})(dx::Adjoint) = adjoint(project.parent(parent(dx)))
-(project::ProjectTo{Adjoint})(dx::Transpose) = adjoint(adjoint.(project.parent(parent(dx)))) # might copy twice?
+(project::ProjectTo{Adjoint})(dx::LinearAlgebra.AdjOrTransAbsVec) = adjoint(project.parent(adjoint(dx)))
 function (project::ProjectTo{Adjoint})(dx::AbstractArray)
     size(dx,1) == 1 && size(dx,2) == length(project.parent.axes[1]) || throw(_projection_mismatch((1:1, project.parent.axes...), size(dx)))
-    dy = project.parent(adjoint(dx))
-    return adjoint(dy)
+    dy = eltype(dx) <: Real ? vec(dx) : adjoint(dx)
+    return adjoint(project.parent(dy))
 end
 
 function ProjectTo(x::LinearAlgebra.TransposeAbsVec)
     sub = ProjectTo(parent(x))
     ProjectTo{Transpose}(; parent=sub)
 end
-(project::ProjectTo{Transpose})(dx::Transpose) = transpose(project.parent(parent(dx)))
-(project::ProjectTo{Transpose})(dx::Adjoint) = transpose(adjoint.(project.parent(parent(dx))))
+(project::ProjectTo{Transpose})(dx::LinearAlgebra.AdjOrTransAbsVec) = transpose(project.parent(transpose(dx)))
 function (project::ProjectTo{Transpose})(dx::AbstractArray)
     size(dx,1) == 1 && size(dx,2) == length(project.parent.axes[1]) || throw(_projection_mismatch((1:1, project.parent.axes...), size(dx)))
-    dy = project.parent(transpose(dx))
-    return transpose(dy)
+    dy = eltype(dx) <: Number ? vec(dx) : transpose(dx)
+    return transpose(project.parent(dy))
 end
 
 # Diagonal

test/projection.jl

@@ -98,7 +98,7 @@ using OffsetArrays, BenchmarkTools
         adjT = typeof(adj([1,2,3.0]))
         @test padj(transpose(1:3)) isa adjT
         @test padj([4 5 6+7im]) isa adjT
-        @test_broken padj([4.0 5.0 6.0]) isa adjT
+        @test padj([4.0 5.0 6.0]) isa adjT
 
         @test_throws DimensionMismatch padj([1,2,3])
         @test_throws DimensionMismatch padj([1 2 3]')
@@ -258,7 +258,7 @@ using OffsetArrays, BenchmarkTools
         @test repr(ProjectTo(1.1)) == "ProjectTo{Float64}()"
         @test occursin("ProjectTo{AbstractArray}(element", repr(ProjectTo([1,2,3])))
         str = repr(ProjectTo([1,2,3]'))
-        @test_broken eval(Meta.parse(str))(ones(1,3)) isa Adjoint{Float64, Vector{Float64}}
+        @test eval(Meta.parse(str))(ones(1,3)) isa Adjoint{Float64, Vector{Float64}}
     end
 
     VERSION > v"1.1" && @testset "allocation tests" begin
@@ -272,7 +272,7 @@ using OffsetArrays, BenchmarkTools
 
         padj = ProjectTo(adjoint(rand(10^3)))
         @test 0 == @ballocated $padj(dx) setup=(dx=adjoint(rand(10^3)))
-        @test_broken 0 == @ballocated $padj(dx) setup=(dx=transpose(rand(10^3)))
+        @test 0 == @ballocated $padj(dx) setup=(dx=transpose(rand(10^3)))
 
         @test 0 == @ballocated ProjectTo(x')(dx') setup=(x=rand(10^3); dx=rand(10^3))