fix deprecated tests

Author: oxinabox

test/deprecated.jl

@@ -1,32 +1,37 @@
 @testset "NO_FIELDS" begin
-    @test (@test_deprecated NO_FIELDS) isa NoTangent
+    # Following doesn't work because of some deprecate_binding weirdness with not printing
+    # @test (@test_deprecated NO_FIELDS) isa NoTangent
+    # So just test it gives the old behavour
+    @test NO_FIELDS isa NoTangent
 end
 
 @testset "extern" begin
-    @test extern(@thunk(3)) == 3
-    @test extern(@thunk(@thunk(3))) == 3
+    @test (@test_deprecated extern(@thunk(3))) == 3
+    @test (@test_deprecated extern(@thunk(@thunk(3)))) == 3
 
-    @test extern(Tangent{Foo}(x=2.0)) == (;x=2.0)
-    @test extern(Tangent{Tuple{Float64,}}(2.0)) == (2.0,)
-    @test extern(Tangent{Dict}(Dict(4 => 3))) == Dict(4 => 3)
+    @test (@test_deprecated extern(Tangent{Foo}(x=2.0))) == (;x=2.0)
+    @test (@test_deprecated extern(Tangent{Tuple{Float64,}}(2.0))) == (2.0,)
+    @test (@test_deprecated extern(Tangent{Dict}(Dict(4 => 3)))) == Dict(4 => 3)
 
     # with differentials on the inside
-    @test extern(Tangent{Foo}(x=@thunk(0+2.0))) == (;x=2.0)
-    @test extern(Tangent{Tuple{Float64,}}(@thunk(0+2.0))) == (2.0,)
-    @test extern(Tangent{Dict}(Dict(4 => @thunk(3)))) == Dict(4 => 3)
+    @test (@test_deprecated extern(Tangent{Foo}(x=@thunk(0+2.0)))) == (;x=2.0)
+    @test (@test_deprecated extern(Tangent{Tuple{Float64,}}(@thunk(0+2.0)))) == (2.0,)
+    @test (@test_deprecated extern(Tangent{Dict}(Dict(4 => @thunk(3))))) == Dict(4 => 3)
 
     z = ZeroTangent()
-    @test extern(z) === false
+    @test (@test_deprecated extern(z)) === false
+    
+    # @test_throws doesn't play nice with `@test_deprecated` so have to be loud
     dne = NoTangent()
     @test_throws Exception extern(dne)
-    E = ChainRulesCore.NotImplementedException
-    @test_throws E extern(ni)
+    ni = @not_implemented("no")
+    @test_throws ChainRulesCore.NotImplementedException extern(ni)
 end
 
 
 @testset "Deprecated: calling thunks should call inner function" begin
-    @test_deprecated (@thunk(3))() == 3
-    @test_deprecated (@thunk(@thunk(3)))() isa Thunk
+    @test (@test_deprecated (@thunk(3))()) == 3
+    @test (@test_deprecated (@thunk(@thunk(3)))()) isa Thunk
 end
 
 @testset "Deprecated: Inplacable Thunk argument order" begin

test/runtests.jl

@@ -21,4 +21,6 @@ using Test
     include("rules.jl")
     include("rule_definition_tools.jl")
     include("config.jl")
+
+    include("deprecated.jl")
 end