Handle rrule(f, x::T) where T #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzgubic
reviewed
Jun 24, 2021
| end | ||
| # New rule should not have appeared | ||
| @test collect(_rule_list(rrule)) == old_rrule_list | ||
| # Above would error if we were not handling UnionAll's right |
Member
There was a problem hiding this comment.
What part is the UnionAll?
I can't construct a method which has a signature of UnionAll actually
Member
Author
There was a problem hiding this comment.
It is a UnionAll over all values F can take
julia> function alt_rrule(
::RuleConfig{>:Union{HasForwardsMode,HasReverseMode}}, sum, f::F, xs
) where F <: Function
return 1.0, x->(x,x,x) # this will not be call so return doesn't matter
end
alt_rrule (generic function with 1 method)
julia> method = first(methods(alt_rrule))
alt_rrule(::RuleConfig{var"#s3"} where var"#s3">:Union{HasForwardsMode, HasReverseMode}, sum, f::F, xs) where F<:Function in Main at REPL[9]:1
julia> method.sig
Tuple{typeof(alt_rrule), RuleConfig{var"#s3"} where var"#s3">:Union{HasForwardsMode, HasReverseMode}, Any, F, Any} where F<:Function
julia> typeof(method.sig)
UnionAll
mzgubic
approved these changes
Jun 24, 2021
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6 +/- ##
=======================================
Coverage 96.29% 96.29%
=======================================
Files 2 2
Lines 54 54
=======================================
Hits 52 52
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the old way caused errors because
sig.parameterscan't be used ifsigis aUnionAll