UndefVarError Random not defined in data_generation.jl (#28)

* Use Random in data_generation; added tests

* Bumped version in Project.toml to 0.2.4

* Address CR feedback

* Removed Test from extras and target section

* Updated testing for well conditioned matrices

* Update test/data_generation.jl

Co-authored-by: Nick Robinson <[email protected]>

* Update test/data_generation.jl

Co-authored-by: Nick Robinson <[email protected]>

* Matrix condition < 100

Co-authored-by: Nick Robinson <[email protected]>

Author: mattBrzezinski

Project.toml

@@ -1,23 +1,17 @@
 name = "ChainRulesTestUtils"
 uuid = "cdddcdb0-9152-4a09-a978-84456f9df70a"
-version = "0.2.3"
+version = "0.2.4"
 
 [deps]
 ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
 Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"
 FiniteDifferences = "26cc04aa-876d-5657-8c51-4c34ba976000"
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
+Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [compat]
 ChainRulesCore = "0.7.1"
 Compat = "3"
 FiniteDifferences = "0.9"
 julia = "1"
-
-[extras]
-Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
-Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
-
-[targets]
-test = ["Random", "Test"]

src/ChainRulesTestUtils.jl

@@ -6,6 +6,7 @@ using Compat: only
 using FiniteDifferences
 using FiniteDifferences: to_vec
 using LinearAlgebra
+using Random
 using Test
 
 const _fdm = central_fdm(5, 1)

test/data_generation.jl

@@ -0,0 +1,24 @@
+@testset "Data Generation" begin
+    function _is_well_conditioned(matrix)
+        @test !isempty(matrix)
+        @test isposdef(matrix)
+        @assert length(matrix) ≤ 25  
+        @test cond(matrix) < 100
+    end
+
+
+    @testset "Generate Well Conditioned Matrix" begin
+        @testset "Pass in RNG" begin
+            rng = MersenneTwister(1)
+            matrix = generate_well_conditioned_matrix(rng, 5)
+
+            _is_well_conditioned(matrix)
+        end
+
+        @testset "Global RNG" begin
+            matrix = generate_well_conditioned_matrix(5)
+
+            _is_well_conditioned(matrix)
+        end
+    end
+end

test/runtests.jl

@@ -1,10 +1,12 @@
 using ChainRulesCore
 using ChainRulesTestUtils
+using LinearAlgebra
 using Random
 using Test
 
 @testset "ChainRulesTestUtils.jl" begin
     include("to_vec.jl")
     include("isapprox.jl")
     include("testers.jl")
+    include("data_generation.jl")
 end