fix: erase cache contexts before building function in Symbolics #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brianguenter do you have any idea why such a fix isn't necessary with FastDifferentiation? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #760 +/- ##
=======================================
Coverage 97.87% 97.87%
=======================================
Files 128 128
Lines 7428 7444 +16
=======================================
+ Hits 7270 7286 +16
Misses 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@gdalle I do not. Symbolics uses very different representations of symbolic expressions than FastDifferentiation does. Somewhere in the nitty gritty details of these differences lies the cause. |
|
Alright, I guess the mystery will remain! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bad cache handling with Symbolics.
The cache variables need to be erased or otherwise replaced before the symbolic function is built. Otherwise the derivatives are deduced from the caches and not from the active variable, as seen in JuliaControl/ModelPredictiveControl.jl#174 (comment)