fix: store sparsity pattern for symbolic backends #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
=======================================
Coverage 97.87% 97.88%
=======================================
Files 128 128
Lines 7444 7464 +20
=======================================
+ Hits 7286 7306 +20
Misses 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gdalle
commented
Mar 31, 2025
DifferentiationInterface/ext/DifferentiationInterfaceSymbolicsExt/twoarg.jl
Outdated
Show resolved
Hide resolved
|
@gdalle tested with |
|
Works with FastDifferentiation too, it might be interesting to compare |
|
I will post the comparison here: JuliaControl/ModelPredictiveControl.jl#174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #763 by giving a
sparsityfield to every sparse Jacobian and Hessian prep type.@franckgaga wanna take it for a spin?