Merge pull request #185 from oscardssmith/minor-improvement

minor test improvements

Author: oscardssmith

Manifest.toml

@@ -465,7 +465,8 @@ function diffract_ir!(ir, ci, meth, sparams::Core.SimpleVector, nargs::Int, N::I
             elseif isexpr(stmt, :static_parameter)
                 fwds[i] = ZeroTangent()
             elseif isa(stmt, Union{GotoNode, GotoIfNot})
-                return :(error("Control flow support not fully implemented yet for higher-order reverse mode (TODO)"))
+                #@show stmt
+                error("Control flow support not fully implemented yet for higher-order reverse mode (TODO)")
             elseif !isa(stmt, Expr)
                 @show stmt
                 error()

src/codegen/reverse.jl

@@ -77,17 +77,17 @@ isa_control_flow(::Type{T}, x) where {T} = isa(x, T) ? x : T(x)
 let var"'" = Diffractor.PrimeDerivativeBack
     # Integration tests
     @test @inferred(sin'(1.0)) == cos(1.0)
-    @test sin''(1.0) == -sin(1.0)
-    @test sin'''(1.0) == -cos(1.0)
+    @test @inferred(sin''(1.0)) == -sin(1.0)
+    @test @inferred(sin'''(1.0)) == -cos(1.0)
     # TODO These currently cause segfaults c.f. https://github.com/JuliaLang/julia/pull/48742
     # @test sin''''(1.0) == sin(1.0)
     # @test sin'''''(1.0) == cos(1.0)
     # @test sin''''''(1.0) == -sin(1.0)
 
     f_getfield(x) = getfield((x,), 1)
     @test f_getfield'(1) == 1
-    @test f_getfield''(1) == 0
-    @test f_getfield'''(1) == 0
+    @test f_getfield''(1) == NoTangent()
+    @test f_getfield'''(1) == NoTangent()
 
     # Higher order mixed mode tests
 
@@ -108,5 +108,4 @@ let var"'" = Diffractor.PrimeDerivativeBack
     @test pow5p(1.0) == 5.0
 end
 
-
 end