misc fixes

Author: Keno

src/extra_rules.jl

@@ -296,7 +296,7 @@ Base.hash(x::ZeroTangent, h::UInt64) = hash(0, h)
 # should this be in ChainRules/ChainRulesCore?
 # Avoid making nested backings, a Tangent is already a valid Tangent for a Tangent, 
 # or a valid second order Tangent for the primal
-function frule((_, ẋ), T::Type{<:Tangent}, x)
+function ChainRulesCore.frule((_, ẋ), T::Type{<:Tangent}, x)
     ẋ::Tangent
     return T(x), ẋ
-end
+end

src/stage1/forward.jl

@@ -33,14 +33,15 @@ function shuffle_down(b::TaylorBundle{N, B}) where {N, B}
         ntuple(_sdown, N-1))
 end
 
+@noinline check_taylor(z₁, z₂) = @assert(z₁ == z₂,  "$z₁ == $z₂")
 
 function shuffle_up(r::TaylorBundle{1, Tuple{B1,B2}}) where {B1,B2}
     z₀ = primal(r)[1]
     z₁ = partial(r, 1)[1]
     z₂ = primal(r)[2]
     z₁₂ = partial(r, 1)[2]
     if true
-        @assert(z₁ == z₂,  "$z₁ == $z₂")
+        check_taylor(z₁, z₂)
         return TaylorBundle{2}(z₀, (z₁, z₁₂))
     else
         return ExplicitTangentBundle{2}(z₀, (z₁, z₂, z₁₂))