Skip to content

Commit 062facc

Browse files
author
oscarddssmith
committed
don\'t assume mutability for out of place
1 parent 02286bc commit 062facc

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

src/jvp.jl

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -84,21 +84,20 @@ function finite_difference_jvp(
8484
if fdtype == Val(:complex)
8585
ArgumentError("finite_difference_jvp doesn't support :complex-mode finite diff")
8686
end
87-
(; x1, fx1) = cache
8887

8988
tmp = sqrt(abs(dot(_vec(x), _vec(v))))
9089
epsilon = compute_epsilon(fdtype, tmp, relstep, absstep, dir)
9190
if fdtype == Val(:forward)
9291
fx = f_in isa Nothing ? f(x) : f_in
93-
@. x1 = x + epsilon * v
92+
x1 = @. x + epsilon * v
9493
fx1 = f(x1)
95-
@. fx1 = (fx1-fx)/epsilon
94+
fx1 = @. (fx1-fx)/epsilon
9695
elseif fdtype == Val(:central)
97-
@. x1 = x + epsilon * v
96+
x1 = @. x + epsilon * v
9897
fx1 = f(x1)
99-
@. x1 = x - epsilon * v
98+
x1 = @. x - epsilon * v
10099
fx = f(x1)
101-
@. fx1 = (fx1-fx)/(2epsilon)
100+
fx1 = @. (fx1-fx)/epsilon
102101
else
103102
fdtype_error(eltype(x))
104103
end

0 commit comments

Comments
 (0)