Skip to content

Commit 2b447e0

Browse files
committed
Remove a redundant Unitful test and clean up TODO comment
1 parent 9d049da commit 2b447e0

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

test/methods.jl

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -96,18 +96,12 @@ struct NotAFunction end # not <: Function on purpose, cf #224
9696

9797
derivativeVal = 5.0u"J/s"
9898

99-
# NOTE: the input value unit is wrong here to make this run at all!
100-
# The unit should be u"s", but it has to be the inverse of the desired output unit.
101-
# TODO: Find out the faulty code path using a debugger.
102-
twoPlaceDerivativeVal = central_fdm(5, 1)(fn, 1.0u"s")
103-
10499
adaptedDerivativeVal = central_fdm(5, 1)(fn, 1.0u"s",1)
105100

106-
@test unit(twoPlaceDerivativeVal) == u"J/s"
107101
@test unit(adaptedDerivativeVal) == u"J/s"
108102

109-
@test isapprox(twoPlaceDerivativeVal, 5.0u"J/s"; rtol=1e-12, atol=1e-12u"J/s")
110-
@test isapprox(adaptedDerivativeVal, 5.0u"J/s"; rtol=1e-12, atol=1e-12u"J/s")
103+
@test isapprox(adaptedDerivativeVal, derivativeVal; rtol=1e-12, atol=1e-12u"J/s")
104+
111105
end
112106

113107
@testset "Adaptation improves estimate" begin

0 commit comments

Comments
 (0)