fix: regression in non-fast scalar indexing support #760
+107
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #760 +/- ##
==========================================
+ Coverage 89.58% 90.07% +0.49%
==========================================
Files 11 12 +1
Lines 1008 1038 +30
==========================================
+ Hits 903 935 +32
+ Misses 105 103 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ext/ForwardDiffGPUArraysCoreExt.jl
Outdated
| idxs = collect( | ||
| Iterators.drop(ForwardDiff.structural_eachindex(result), offset) | ||
| )[1:chunksize] | ||
| result[idxs] .= partial_fn.(Ref(dual), 1:chunksize) |
There was a problem hiding this comment.
Does this not have an inference issue due to losing static information about size? I would think this needs to be ntuple unless it can prove things about size.
There was a problem hiding this comment.
It would still be type-stable, it would just have dynamism in the function that would slow it down a bit during the broadcast.
There was a problem hiding this comment.
Here the chunksize is already an Int, so I don't think we will have any benefit of using an ntuple
ChrisRackauckas
added a commit
that referenced
this pull request
Aug 14, 2025
Noted in #759 (comment), GPU is completely untested in ForwardDiff.jl, so this sets up the buildkite pipeline. I setup the backend and all, and just took a few tests from #760 to seed it. The point of this isn't really to be a comprehensive set of GPU tests but rather to update this repo to have the standard tools the other repos have so GPU doesn't regress again/more.
devmotion
reviewed
Aug 15, 2025
avik-pal
force-pushed
the
ap/gpu_arrays
branch
3 times, most recently
from
19e8423 to
da2efb7
Compare
devmotion
reviewed
Aug 17, 2025
avik-pal
force-pushed
the
ap/gpu_arrays
branch
from
26c1ec9 to
c4c62a4
Compare
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
avik-pal
force-pushed
the
ap/gpu_arrays
branch
from
2536221 to
11540a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #759
ForwardDiff.gradientnow supports GPU Arrayscc @ChrisRackauckas @devmotion