Skip to content

Commit 534c2d2

Browse files
committed
fix a version check in the tests
also, don't kill the test suite when julia nightly isn't in the shape
1 parent 3e32694 commit 534c2d2

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ jobs:
3636
${{ runner.os }}-test-
3737
${{ runner.os }}-
3838
- uses: julia-actions/julia-runtest@latest
39+
continue-on-error: ${{ matrix.version == 'nightly' }}
3940
- uses: julia-actions/julia-processcoverage@v1
4041
- uses: codecov/codecov-action@v1
4142
with:

test/tests.jl

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -342,12 +342,13 @@ end
342342
DSE.format(DSE.TYPEDSIGNATURES, buf, doc)
343343
str = String(take!(buf))
344344
@test occursin("\n```julia\n", str)
345-
if VERSION > v"1.7" || VERSION < v"1.1"
346-
@test occursin("\nk_7(\n x::Union{Nothing, T} where T<:Integer\n) -> Union{Nothing, T} where T<:Integer\n", str)
347-
else
345+
if VERSION >= v"1.6" && VERSION < v"1.7"
348346
@test occursin("\nk_7(\n x::Union{Nothing, T} where T<:Integer\n) -> Union{Nothing, Integer}\n", str)
347+
@test occursin("\nk_7(\n x::Union{Nothing, T} where T<:Integer,\n y::Integer\n) -> Union{Nothing, Integer}\n", str)
348+
else
349+
@test occursin("\nk_7(\n x::Union{Nothing, T} where T<:Integer\n) -> Union{Nothing, T} where T<:Integer\n", str)
350+
@test occursin("\nk_7(\n x::Union{Nothing, T} where T<:Integer,\n y::Integer\n) -> Union{Nothing, T} where T<:Integer\n", str)
349351
end
350-
@test occursin("\nk_7(\n x::Union{Nothing, T} where T<:Integer,\n y::Integer\n) -> Union{Nothing, T} where T<:Integer\n", str)
351352
@test occursin("\n```\n", str)
352353

353354
doc.data = Dict(

0 commit comments

Comments
 (0)