Feature/add typed method list abbreviation #153
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/abbreviations.jl
Outdated
| local groups = methodgroups(func, typesig, modname; exact = false) | ||
| if !isempty(groups) | ||
|
|
||
| #START OF COPIED CODE FROM TYPEDMETHODSIGNATURES |
There was a problem hiding this comment.
@unnamedunknownusername could this code just be refactored out into a reusable function rather than copying it across?
There was a problem hiding this comment.
@MichaelHatherly Have seperated out repeated code into a resusable function let me know if I have missed anything
|
(Will need some tests as well before merging is possible.) |
add testset for typed method list
I have added a section in the tests for typed method list testset. But I am thinking we probably need more/want more comprehensive ones Also how can I run the tests locally/verify that the ones I add are passing. Sorry if those are simple questions, just having a little difficulty with this part |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for #150
Essentially just copying the code from
MethodListand creatingTypedMethodListThen inserting a copy of a section of typed signatures into the right spot
@MichaelHatherly, let me know if I have missed anything