Skip to content

Commit 7baea85

Browse files
Seelengrabmortenpifingolfin
authored
Fix empty lines being generated in LaTeX output for hidden @repl entries (#2056)
Co-authored-by: Morten Piibeleht <[email protected]> Co-authored-by: Max Horn <[email protected]>
1 parent 2a36a4a commit 7baea85

File tree

4 files changed

+40
-4
lines changed

4 files changed

+40
-4
lines changed

CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1212
## Fixed
1313

1414
* Don't require custom themes to set a color for the 'todo' admonition. ([#2576])
15-
15+
* Entries in `@repl` blocks that were hidden with `# hide` no longer produce erroneous empty lines ([#1521], [#2054], [#2399])
1616

1717
## Version [v1.9.0] - 2025-03-17
1818

@@ -1678,6 +1678,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
16781678
[#1518]: https://github.com/JuliaDocs/Documenter.jl/issues/1518
16791679
[#1519]: https://github.com/JuliaDocs/Documenter.jl/issues/1519
16801680
[#1520]: https://github.com/JuliaDocs/Documenter.jl/issues/1520
1681+
[#1521]: https://github.com/JuliaDocs/Documenter.jl/issues/1521
16811682
[#1526]: https://github.com/JuliaDocs/Documenter.jl/issues/1526
16821683
[#1527]: https://github.com/JuliaDocs/Documenter.jl/issues/1527
16831684
[#1529]: https://github.com/JuliaDocs/Documenter.jl/issues/1529
@@ -1849,6 +1850,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
18491850
[#2019]: https://github.com/JuliaDocs/Documenter.jl/issues/2019
18501851
[#2027]: https://github.com/JuliaDocs/Documenter.jl/issues/2027
18511852
[#2051]: https://github.com/JuliaDocs/Documenter.jl/issues/2051
1853+
[#2054]: https://github.com/JuliaDocs/Documenter.jl/issues/2054
18521854
[#2058]: https://github.com/JuliaDocs/Documenter.jl/issues/2058
18531855
[#2066]: https://github.com/JuliaDocs/Documenter.jl/issues/2066
18541856
[#2067]: https://github.com/JuliaDocs/Documenter.jl/issues/2067
@@ -1933,6 +1935,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
19331935
[#2375]: https://github.com/JuliaDocs/Documenter.jl/issues/2375
19341936
[#2378]: https://github.com/JuliaDocs/Documenter.jl/issues/2378
19351937
[#2394]: https://github.com/JuliaDocs/Documenter.jl/issues/2394
1938+
[#2399]: https://github.com/JuliaDocs/Documenter.jl/issues/2399
19361939
[#2406]: https://github.com/JuliaDocs/Documenter.jl/issues/2406
19371940
[#2408]: https://github.com/JuliaDocs/Documenter.jl/issues/2408
19381941
[#2410]: https://github.com/JuliaDocs/Documenter.jl/issues/2410

src/expander_pipeline.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -926,8 +926,8 @@ function Selectors.runner(::Type{Expanders.REPLBlocks}, node, page, doc)
926926

927927
outstr = String(take!(out))
928928
# Replace references to gensym'd module with Main
929-
outstr = remove_sandbox_from_output(outstr, mod)
930-
push!(multicodeblock, MarkdownAST.CodeBlock("documenter-ansi", rstrip(outstr)))
929+
outstr = rstrip(remove_sandbox_from_output(outstr, mod))
930+
!isempty(outstr) && push!(multicodeblock, MarkdownAST.CodeBlock("documenter-ansi", outstr))
931931
end
932932
node.element = Documenter.MultiCodeBlock(x, "julia-repl", [])
933933
for element in multicodeblock

test/examples/references/latex_simple.tex

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
\newcommand{\DocMainTitle}{Documenter LaTeX Simple Non-Docker}
33
\newcommand{\DocVersion}{1.2.3}
44
\newcommand{\DocAuthors}{}
5-
\newcommand{\JuliaVersion}{1.11.1}
5+
\newcommand{\JuliaVersion}{1.11.4}
66

77
% ---- Insert preamble
88
\input{preamble.tex}
@@ -254,4 +254,26 @@ \section{Issue 2300}
254254
255255
256256
257+
\section{PR 2056}
258+
259+
260+
261+
\label{1659457410429464311}{}
262+
263+
264+
Issues: \texttt{\#1521}, \texttt{\#2054}, \texttt{\#2399}
265+
266+
267+
268+
269+
\begin{minted}{jlcon}
270+
julia> println(x)
271+
2
272+
273+
julia> x
274+
2
275+
\end{minted}
276+
277+
278+
257279
\end{document}

test/examples/src.latex_simple/index.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,3 +131,14 @@ lines**.
131131
## Issue 2300
132132

133133
You Shall Not Break! You Shall Not Break! You Shall Not Break!
134+
135+
## PR 2056
136+
137+
Issues: `#1521`, `#2054`, `#2399`
138+
139+
```@repl
140+
x = 1 # hide
141+
x = 2 # hide
142+
println(x)
143+
x
144+
```

0 commit comments

Comments
 (0)