remove .includes and add a set to make it O(n) #2875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
don't think it needs a changelog since it's an optimization and not a user facing change |
Collaborator
|
Thanks a lot @Rahban1. Don't worry, to err is human, and e.g. I didn't catch this in review either -- and it works fine for e.g. the Julia website. Regarding the changelog, I'd still like to have an entry so that people wondering "should I bother to use this" will know that this issue was there and has been fixed. |
Contributor
Author
|
I guess this is ready to merge from my side |
fingolfin
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologize for the slowdown in search, I should have thought about this O(n^2) time complexity earlier and should have optimized it.
This closes #2872