Skip to content

Commit 045055f

Browse files
committed
add news and fix some spelling mistakes
1 parent e77191d commit 045055f

File tree

4 files changed

+17
-9
lines changed

4 files changed

+17
-9
lines changed

NEWS.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,16 @@
11
# NetworkDynamics Release Notes
22

3+
## v0.10.4 Changelog
4+
- [#303](https://github.com/JuliaDynamics/NetworkDynamics.jl/pull/303) update for ModelingToolkit.jl v10 compatibility:
5+
- rename all `ODESystem` -> `System` (follows MTK v10 API)
6+
- MTK extension now uses `mtkcompile` instead of `structural_simplify` internally
7+
- Add new `implicit_output` function to handle fully implicit output variables in MTK models
8+
- Add documentation for handling fully implicit outputs in MTK integration
9+
- Update minimum ModelingToolkit.jl requirement from v9.67 to v10
10+
311
## v0.10.3 Changelog
412
- [#301](https://github.com/JuliaDynamics/NetworkDynamics.jl/pull/301) improve callback system performance and flexibility:
5-
- Add callback batching for better DiscreteComponentCallback performance
13+
- Add callback batching for better DiscreteComponentCallback performance
614
- Allow `EIndex(1=>2)` as standalone edge index with relaxed type constraints
715
- Optimize CallbackSet construction to prevent performance bottlenecks
816
- Add important documentation warning about parameter array copying in callbacks

ext/MTKExt_utils.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ function warn_missing_features(sys)
152152
cev = ModelingToolkit.get_continuous_events(sys)
153153
dev = ModelingToolkit.get_discrete_events(sys)
154154
if !isempty(cev) || !isempty(dev)
155-
@warn "Model has attached events, which is not supportet."
155+
@warn "Model has attached events, which is not supported."
156156
end
157157

158158
if !isempty(ModelingToolkit.initialization_equations(sys))

ext/NetworkDynamicsMTKExt.jl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Additional kw arguments:
3434
- `name`: Set name of the component model. Will be lifted from the System name.
3535
- `extin=nothing`: Provide external inputs as pairs, i.e. `extin=[:extvar => VIndex(1, :a)]`
3636
will bound the variable `extvar(t)` in the equations to the state `a` of the first vertex.
37-
- `ff_to_constraint=true`: Controlls, whether output transformations `g` which depend on inputs should be
37+
- `ff_to_constraint=true`: Controls, whether output transformations `g` which depend on inputs should be
3838
transformed into constraints. Defaults to true since ND.jl does not handle vertices with FF yet.
3939
"""
4040
function VertexModel(sys::System, inputs, outputs; verbose=false, name=getname(sys),
@@ -96,7 +96,7 @@ end
9696
Create a `EdgeModel` object from a given `System` created with ModelingToolkit for **single sided models**.
9797
9898
Here you only need to provide one list of output symbols: `dstout`.
99-
To make it clear how to handle the single-sided output definiton, you musst wrap
99+
To make it clear how to handle the single-sided output definition, you must wrap
100100
the symbol vector in
101101
- `AntiSymmetric(dstout)`,
102102
- `Symmetric(dstout)`, or
@@ -121,7 +121,7 @@ Additional kw arguments:
121121
- `name`: Set name of the component model. Will be lifted from the System name.
122122
- `extin=nothing`: Provide external inputs as pairs, i.e. `extin=[:extvar => VIndex(1, :a)]`
123123
will bound the variable `extvar(t)` in the equations to the state `a` of the first vertex.
124-
- `ff_to_constraint=false`: Controlls, whether output transformations `g` which depend on inputs should be
124+
- `ff_to_constraint=false`: Controls, whether output transformations `g` which depend on inputs should be
125125
transformed into constraints.
126126
"""
127127
function EdgeModel(sys::System, srcin, dstin, srcout, dstout; verbose=false, name=getname(sys),
@@ -141,7 +141,7 @@ function EdgeModel(sys::System, srcin, dstin, srcout, dstout; verbose=false, nam
141141
singlesided = isnothing(srcout)
142142
if singlesided && !(dstout isa AnnotatedSym)
143143
throw(ArgumentError("If you only provide one output (single sided \
144-
model), it musst be wrapped either in `AntiSymmetric`, `Symmetric` or \
144+
model), it must be wrapped either in `AntiSymmetric`, `Symmetric` or \
145145
`Directed`!"))
146146
end
147147

@@ -312,8 +312,8 @@ function generate_io_function(_sys, inputss::Tuple, outputss::Tuple;
312312
mtkcompile(_sys; inputs=_openinputs, outputs=alloutputs, simplify=false)
313313
catch e
314314
if e isa ModelingToolkit.ExtraEquationsSystemException
315-
msg = "The system could not be compiled becaus of extra equations! \
316-
Somtimes, this can be related to fully implicit output equations. \
315+
msg = "The system could not be compiled because of extra equations! \
316+
Sometimes, this can be related to fully implicit output equations. \
317317
Check `@doc implicit_output` for more information."
318318
throw(ArgumentError(msg))
319319
end

src/utils.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,6 @@ equation depends on `x`. This can be necessary to define a model with fully impl
248248
249249
$implicit_output_docstring
250250
251-
For more information see the NetworkDyanmics docs on [Fully Implicit Outputs](@ref).
251+
For more information see the NetworkDynamics docs on [Fully Implicit Outputs](@ref).
252252
"""
253253
implicit_output(x) = 0

0 commit comments

Comments
 (0)