coverage leads to test failure, separate cov from test

Author: hexaeder

.github/workflows/tests.yml

@@ -8,7 +8,7 @@ on:
 concurrency:
   # Skip intermediate builds: always.
   group: ${{ github.workflow }}-${{ github.ref }}
-  cancel-in-progress: true # allways cancle old runs on new push
+  cancel-in-progress: true # always cancle old runs on new push
 jobs:
   test:
     name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }}
@@ -38,6 +38,28 @@ jobs:
       - uses: julia-actions/cache@v2
       - uses: julia-actions/julia-buildpkg@v1
       - uses: julia-actions/julia-runtest@v1
+        with:
+          coverage: false
+
+  test-coverage:
+    name: Test Coverage
+    runs-on: ubuntu-latest
+    permissions: # needed to allow julia-actions/cache to proactively delete old caches that it has created
+      actions: write
+      contents: read
+    steps:
+      - uses: actions/checkout@v4
+      - uses: julia-actions/setup-julia@v2
+        with:
+          version: 1
+          arch: x64
+      - uses: julia-actions/cache@v2
+      - uses: julia-actions/julia-buildpkg@v1
+      - uses: julia-actions/julia-runtest@v1
+        env:
+          JULIA_COVERAGE: true
+        with:
+          coverage: true
       - uses: julia-actions/julia-processcoverage@v1
       - uses: codecov/codecov-action@v4
         with:

Project.toml

@@ -59,7 +59,7 @@ KernelAbstractions = "0.9.18"
 LinearAlgebra = "1"
 MacroTools = "0.5.15"
 Mixers = "0.1.2"
-ModelingToolkit = "9.61"
+ModelingToolkit = "9.67"
 NNlib = "0.9.13"
 NonlinearSolve = "4"
 Polyester = "0.7.12"

docs/examples/cascading_failure.jl

@@ -245,8 +245,8 @@ prob = ODEProblem(nw, uflat(u0), (0,6), pflat(u0); callback=cbset)
 Main.test_execution_styles(prob) # testing all ex styles #src
 sol2 = solve(prob, Tsit5());
 ## we want to test the reconstruction of the observables # hide
-@test all(!iszero, sol2(sol2.t; idxs=eidxs(sol2,:,:P))[begin]) # hide
-@test all(iszero, sol2(sol2.t; idxs=eidxs(sol2,:,:P))[end][[1:5...,7]]) # hide
+@test all(!iszero, sol2(sol2.t; idxs=eidxs(sol2,:,:P)).u[begin]) # hide
+@test all(iszero, sol2(sol2.t; idxs=eidxs(sol2,:,:P)).u[end][[1:5...,7]]) # hide
 nothing #hide
 
 # Then again we plot the solution:

src/symbolicindexing.jl

@@ -782,9 +782,9 @@ function NWState(sol::SciMLBase.AbstractODESolution, t::Number)
 
     tidx = findfirst(_t -> _t > t, para_ts.t)
     p = if isnothing(tidx)
-        para_ts[end]
+        para_ts.u[end]
     else
-        para_ts[tidx-1]
+        para_ts.u[tidx-1]
     end
 
     NWState(sol, u, p, t)

test/construction_test.jl

@@ -402,7 +402,11 @@ end
         u2 = vcat(u, out)
         # compfg(v2)((out2,), du2, u2, (in,), p, NaN)
         b = @b $(compfg(v2))($(out2,), $du2, $u2, $(in,), $p, NaN)
-        @test b.allocs == 0
+        if haskey(ENV, "JULIA_COVERAGE")
+            @test b.allocs ≤ 6 # decreased performacen due to coverage sideeffects
+        else
+            @test b.allocs == 0
+        end
         @test out ≈ out2
         @test du2 ≈ vcat(du, zeros(length(out)))
     end