Skip to content

Commit ade211e

Browse files
committed
better assset handling
1 parent 1dda5cc commit ade211e

File tree

4 files changed

+12
-20
lines changed

4 files changed

+12
-20
lines changed

NetworkDynamicsInspector/src/NetworkDynamicsInspector.jl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,11 @@ using Graphs: nv, ne
1313
using GraphMakie
1414
using GraphMakie.NetworkLayout
1515

16+
const JQUERY = Asset("https://cdn.jsdelivr.net/npm/[email protected]/dist/jquery.min.js")
17+
const SELECT2_CSS = Asset("https://cdn.jsdelivr.net/npm/[email protected]/dist/css/select2.min.css")
18+
const SELECT2_JS = Asset("https://cdn.jsdelivr.net/npm/[email protected]/dist/js/select2.min.js")
19+
const APP_CSS = Asset(joinpath(pkgdir(NetworkDynamicsInspector), "assets", "app.css"))
20+
1621
export ContinuousSlider, RoundedLabel
1722
include("widgets.jl")
1823

NetworkDynamicsInspector/src/utils.jl

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,3 @@
1-
2-
function wrap_assets(appdom)
3-
jquery = Asset("https://cdn.jsdelivr.net/npm/[email protected]/dist/jquery.min.js")
4-
select2_css = Asset("https://cdn.jsdelivr.net/npm/[email protected]/dist/css/select2.min.css")
5-
select2_js = Asset("https://cdn.jsdelivr.net/npm/[email protected]/dist/js/select2.min.js")
6-
css = Asset(joinpath(pkgdir(NetworkDynamicsInspector), "assets", "app.css"))
7-
8-
DOM.body(
9-
jquery,
10-
select2_css,
11-
select2_js,
12-
css,
13-
appdom;
14-
)
15-
end
16-
171
function gen_state_options(nw::Network, sidxs)
182
options = OptionGroup{Symbol}[]
193
isempty(sidxs) && return options

NetworkDynamicsInspector/src/widgets.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -398,9 +398,9 @@ function Bonito.jsrender(session::Session, multiselect::MultiSelect)
398398
)
399399

400400
container = DOM.div(
401-
# jquery,
402-
# select2_css,
403-
# select2_js,
401+
JQUERY,
402+
SELECT2_CSS,
403+
SELECT2_JS,
404404
select
405405
)
406406

test/Inspector_test.jl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,8 @@ app = (;
8383

8484
let
8585
isfile(WGLMakie.WGL.bundle_file) && rm(WGLMakie.WGL.bundle_file)
86+
bonitobundle = joinpath(pkgdir(Bonito), "js_dependencies", "Bonito.bundled.js")
87+
ispath(bonitobundle) && rm(bonitobundle)
8688
_app = App() do session
8789
@info "start new session"
8890
WGLMakie.activate!(resize_to=:parent)
@@ -125,6 +127,7 @@ let
125127
Bonito.evaljs(session, resize_gp)
126128

127129
DOM.div(
130+
NetworkDynamicsInspector.APP_CSS,
128131
DOM.div(
129132
NetworkDynamicsInspector.graphplot_card(app),
130133
NetworkDynamicsInspector.gpstate_control_card(app, :vertex),
@@ -142,7 +145,7 @@ let
142145
class="timeseries-col"
143146
),
144147
class="maingrid"
145-
) |> wrap_assets
148+
)
146149
end;
147150
serve_app(_app)
148151
end

0 commit comments

Comments
 (0)