Fix inbounds check for Albers projections.#338
Closed
jamesrhester wants to merge 1 commit intoJuliaEarth:mainfrom
Closed
Fix inbounds check for Albers projections.#338jamesrhester wants to merge 1 commit intoJuliaEarth:mainfrom
jamesrhester wants to merge 1 commit intoJuliaEarth:mainfrom
Conversation
The previous inbounds check checked for a negative value after taking the square root and dividing by a possibly negative number, instead of before the square root.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
- Coverage 92.15% 92.05% -0.10%
==========================================
Files 40 40
Lines 1809 1812 +3
==========================================
+ Hits 1667 1668 +1
- Misses 142 144 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Closing in favor of #337 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous
inboundscheck for Albers projections flagged an error on receiving a negative return value for_ambersρ, that is, after taking the square root and dividing by a potentially valid negative number. Theforwardfunction also used the same check. The exit on negative value should have been before taking the square root in_ambersρ. This pull request replaces the original checks with a check for aDomainErrorarising from the_ambersρcall. No check is inserted in_ambersρ, so that in can execute more efficiently in the more likely case that the values it is provided are within the valid domain.